84400[TASK] Update card layout and heading structure in "About" module
Commit message
Review
-
Code review CR +2 Done
- Jasmina Ließmann +2
- Andreas Nedbal +1
- Garvin Hicking +1
-
Verified V +2 Done
- Jasmina Ließmann +2
- Andreas Nedbal +1
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 11
- Build/Sources/Sass/module/_about.scssnew+12 −0
- Build/Sources/Sass/backend.scss+1 −0
- typo3/sysext/backend/Resources/Private/Language/Modules/about.xlf+19 −1
- typo3/sysext/backend/Resources/Private/Partials/About/CoreTeam.html+3 −3
- typo3/sysext/backend/Resources/Private/Partials/About/Credits.html+3 −3
- typo3/sysext/backend/Resources/Private/Partials/About/Donation.html4+3 −3
- typo3/sysext/backend/Resources/Private/Partials/About/Extensions.html+29 −41
- typo3/sysext/backend/Resources/Private/Partials/About/ExternalLibraries.html+18 −13
- typo3/sysext/backend/Resources/Private/Partials/About/Modules.html4+41 −26
- typo3/sysext/backend/Resources/Private/Templates/About/Index.html+4 −2
- typo3/sysext/backend/Resources/Public/Css/backend.css+2 −0
Review log 1519
-
Jasmina Ließmann uploaded patch set 1 05/25/24, 14:25
-
core-ci voted on patch set 1 V -1 05/25/24, 14:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58219
-
Jasmina Ließmann uploaded patch set 2
V -106/08/24, 20:23 -
core-ci voted on patch set 2 V +1 06/08/24, 20:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58929
-
Jasmina Ließmann updated the commit message in patch set 3
V +106/08/24, 20:34 -
core-ci voted on patch set 3 V +1 06/08/24, 20:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58930
-
Riccardo De Contardi commented on patch set 3 06/08/24, 20:59
Modules.html:48I don't know if it is a good idea to repeat a button "switch to module" for each card... I'd try to pop down it (link-styled button) Sometimes in the card description there is the italic text "Access for 'admin' users only!" - IMHO that should be more evident -
Garvin Hicking commented on patch set 3 CR +1 V +1 06/08/24, 21:03
Tested on macOS in Firefox, Safari and Chromium with varying font sizes and looks good to me. Also on iOS in landscape+portrait mode. -
Jasmina Ließmann commented on patch set 3 06/08/24, 21:35
Donation.html:9ReplyAccording to EXT:styleguide, there are currently five button colors, with gray being the standard color. Buttons in orange, red and green are currently used in the system for warning or success messages. Therefore, I would advise against using these colors for other purposes. Is this ok for you?Modules.html:48ReplyLinks at the end of a card are always displayed as such a button. In order to achieve a uniform appearance between the various card occurrences, I would leave it as it is. I initially picked up the submodule title in the button label, but then I found this to be too much of a duplicate and in some cases too long text - hence the current short, albeit repetitive, form. I would be reluctant to use a new/different type of link here. If you have any suggestions for labels, please let me know! :) "Access for 'admin' users only!" - This designation is currently part of the XLF labels/keys and we would be happy to address it with another patch. -
Riccardo De Contardi commented on patch set 3 06/08/24, 21:44
Donation.html:9ReplyFine for meModules.html:48ReplyI agree that repeating the title would be too long; I think that the btn btn-link style would be fine in this case... Everything depends on how much you want/need to draw attention upon that buttons. Mine are just suggestions, that's all. OK for the rest -
Jasmina Ließmann commented on patch set 3 06/08/24, 21:46
Donation.html:9ReplyDone -
morgane garcia voted on patch set 3 CR +1 V +1 06/10/24, 10:46
-
Jasmina Ließmann uploaded patch set 4
CR +1V +106/10/24, 11:49 -
Jasmina Ließmann commented on patch set 4 06/10/24, 11:54
Modules.html:48ReplyI spoke to @michael.telgkamp@mindscreen.de and we go with the submodule titles as part of the button labels. In another patch we can address the partly poor subtitles, a different place for the access hint and could introduce a link title variable. -
Garvin Hicking voted on patch set 4 CR +1 V +1 06/10/24, 11:59
-
core-ci voted on patch set 4 V +1 06/10/24, 12:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59000
-
Andreas Nedbal voted on patch set 4 CR +1 V +1 06/10/24, 19:40
-
Jasmina Ließmann voted on patch set 4 CR +2 V +2 06/10/24, 19:42
-
Jasmina Ließmann merged patch set 5 06/10/24, 19:42
Donation.html:9