Review main Merged

84400[TASK] Update card layout and heading structure in "About" module

Jasmina Ließmann CR +2 V +2 Normal +135 −92 updated 06/10/24, 19:42

Commit message

The "About" backend module provides overviews of the modules available
in the system, installed external libraries, authors of installed
extensions, as well as general information about TYPO3 and its
community.

This patch standardizes the appearance of the cards in this module with
those from the "Admin Tools" area. In addition, the heading structure
has been updated and some headings have been added.

In addition, links are now colored blue, similar to those in the
"System Information" toolbar element, and email links in the extension
authors list were removed because they violated the Content Security
Policy.

Review

  • Code review CR +2 Done
    • Jasmina Ließmann +2
    • Andreas Nedbal +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Jasmina Ließmann +2
    • Andreas Nedbal +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 1519

  1. Jasmina Ließmann uploaded patch set 1 05/25/24, 14:25

  2. core-ci voted on patch set 1 V -1 05/25/24, 14:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58219

  3. Jasmina Ließmann uploaded patch set 2 V -1 06/08/24, 20:23

  4. core-ci voted on patch set 2 V +1 06/08/24, 20:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58929

  5. Jasmina Ließmann updated the commit message in patch set 3 V +1 06/08/24, 20:34

  6. core-ci voted on patch set 3 V +1 06/08/24, 20:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58930

  7. Riccardo De Contardi commented on patch set 3 06/08/24, 20:59

    Donation.html:9

    Would it be possible to pop out this button? Maybe orange?

    Modules.html:48

    I don't know if it is a good idea to repeat a button "switch to module" for each card... I'd try to pop down it (link-styled button) Sometimes in the card description there is the italic text "Access for 'admin' users only!" - IMHO that should be more evident
  8. Garvin Hicking commented on patch set 3 CR +1 V +1 06/08/24, 21:03

    Tested on macOS in Firefox, Safari and Chromium with varying font sizes and looks good to me. Also on iOS in landscape+portrait mode.
  9. Jasmina Ließmann commented on patch set 3 06/08/24, 21:35

    Donation.html:9 Reply

    According to EXT:styleguide, there are currently five button colors, with gray being the standard color. Buttons in orange, red and green are currently used in the system for warning or success messages. Therefore, I would advise against using these colors for other purposes. Is this ok for you?

    Modules.html:48 Reply

    Links at the end of a card are always displayed as such a button. In order to achieve a uniform appearance between the various card occurrences, I would leave it as it is. I initially picked up the submodule title in the button label, but then I found this to be too much of a duplicate and in some cases too long text - hence the current short, albeit repetitive, form. I would be reluctant to use a new/different type of link here. If you have any suggestions for labels, please let me know! :) "Access for 'admin' users only!" - This designation is currently part of the XLF labels/keys and we would be happy to address it with another patch.
  10. Riccardo De Contardi commented on patch set 3 06/08/24, 21:44

    Donation.html:9 Reply

    Fine for me

    Modules.html:48 Reply

    I agree that repeating the title would be too long; I think that the btn btn-link style would be fine in this case... Everything depends on how much you want/need to draw attention upon that buttons. Mine are just suggestions, that's all. OK for the rest
  11. Jasmina Ließmann commented on patch set 3 06/08/24, 21:46

    Donation.html:9 Reply

    Done
  12. morgane garcia voted on patch set 3 CR +1 V +1 06/10/24, 10:46

  13. Jasmina Ließmann uploaded patch set 4 CR +1 V +1 06/10/24, 11:49

  14. Jasmina Ließmann commented on patch set 4 06/10/24, 11:54

    Modules.html:48 Reply

    I spoke to @michael.telgkamp@mindscreen.de and we go with the submodule titles as part of the button labels. In another patch we can address the partly poor subtitles, a different place for the access hint and could introduce a link title variable.
  15. Garvin Hicking voted on patch set 4 CR +1 V +1 06/10/24, 11:59

  16. core-ci voted on patch set 4 V +1 06/10/24, 12:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59000

  17. Andreas Nedbal voted on patch set 4 CR +1 V +1 06/10/24, 19:40

  18. Jasmina Ließmann voted on patch set 4 CR +2 V +2 06/10/24, 19:42

  19. Jasmina Ließmann merged patch set 5 06/10/24, 19:42