84403[TASK] Avoid wantTo() and wantToTest() in ac tests
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 12
- typo3/sysext/core/Tests/Acceptance/Application/BackendUser/ListUserCest.php+2 −17
- typo3/sysext/core/Tests/Acceptance/Application/Extensionmanager/InstalledExtensionsCest.php+0 −1
- typo3/sysext/core/Tests/Acceptance/Application/FileList/FileMetaDataCest.php+0 −1
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/Inline1nCest.php+0 −11
- typo3/sysext/core/Tests/Acceptance/Application/General/ModuleMenuCest.php+0 −6
- typo3/sysext/core/Tests/Acceptance/Application/Login/BackendLoginCest.php+2 −6
- typo3/sysext/core/Tests/Acceptance/Application/RecordList/RecordDownloadCest.php+0 −2
- typo3/sysext/core/Tests/Acceptance/Application/RecordList/SysNoteCest.php+0 −2
- typo3/sysext/core/Tests/Acceptance/Application/Scheduler/TasksCest.php7+2 −7
- typo3/sysext/core/Tests/Acceptance/Application/Template/TemplateCest.php+6 −13
- typo3/sysext/core/Tests/Acceptance/Application/Topbar/ModuleMenuButtonCest.php+0 −4
- typo3/sysext/core/Tests/Acceptance/Application/Topbar/NavigationComponentTreeCest.php+0 −6
Review log 1518
-
Garvin Hicking uploaded patch set 1 05/25/24, 23:10
-
Garvin Hicking commented on patch set 1 05/25/24, 23:11
This may help for better readability of this flailing test cest? -
core-ci voted on patch set 1 V +1 05/25/24, 23:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58231
-
Christian Kuhn commented on patch set 1 CR -1 05/26/24, 06:56
TasksCest.php:39what's the point? that's close to indentical to the method name and follows it directly in the output? -
Garvin Hicking commented on patch set 1 05/26/24, 07:30
TasksCest.php:39ReplyThe point is the output difference. Without it the output says twice "click save". Thats not what the test is about. -
Christian Kuhn commented on patch set 1 05/26/24, 09:18
TasksCest.php:39Replyremove the $I->wantTo('Click "Save"'); then? i'm not a huge fan of wantTo() - they tend to be more puzzling than helpful. -
Garvin Hicking uploaded patch set 2
CR -1V +105/27/24, 07:50Remove wantTo -
Garvin Hicking commented on patch set 2 05/27/24, 07:51
TasksCest.php:39ReplySure, that could work too. Adapted the patch. BTW, I had the failure on my local acceptance test (ran via `./Build/Scripts/runTests.sh -s acceptance typo3/sysext/core/Tests/Acceptance/Application/Scheduler/TasksCest.php`) too once now. -
core-ci voted on patch set 2 V +1 05/27/24, 07:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58324
-
Benjamin Franzke commented on patch set 2 CR -1 05/27/24, 08:19
TasksCest.php:39ReplyI think the commit message now needs to be adapted accordingly, right(?) -
Garvin Hicking commented on patch set 2 05/27/24, 08:30
TasksCest.php:39ReplyIMO not, because by removing "wantTo" the specifity now falls back to the name of the method. But open to suggestions, feel free to edit the title please :-) -
Christian Kuhn uploaded patch set 3
CR -1V +105/27/24, 08:53 -
Christian Kuhn commented on patch set 3 05/27/24, 08:54
TasksCest.php:39ReplyDone -
core-ci voted on patch set 3 V +1 05/27/24, 09:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58329
-
Christian Kuhn voted on patch set 3 CR +1 V +1 05/27/24, 09:28
-
Stefan Bürk voted on patch set 3 CR +1 V +1 05/27/24, 09:38
-
Christian Kuhn voted on patch set 3 CR +2 V +2 05/27/24, 12:01
-
Christian Kuhn merged patch set 4 05/27/24, 12:01