Review main Abandoned

84404[FEATURE] Dipatch event in FormEngine AbstractNode

Sybille Peters CR 0 V 0 Hard +276 −13 updated 05/26/24, 09:30

Commit message

In event is dispatched in AbstractNode::initializeResultArray()
in order to provide more possibilities for extension authors
to customize FormEngine behaviour.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 9

Review log 79

  1. Sybille Peters uploaded patch set 1 05/26/24, 06:45

  2. core-ci voted on patch set 1 V -1 05/26/24, 06:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58252

  3. Sybille Peters uploaded patch set 2 V -1 05/26/24, 06:50

  4. core-ci voted on patch set 2 V -1 05/26/24, 06:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58253

  5. Christian Kuhn commented on patch set 2 05/26/24, 07:03

    it kinda feels as if this general event is not a good solution to the issue you're trying to solve: too big hammer for a too small problem. it's also not how formEngine is supposed to work: single containers should be substituted if they don't fit. -1 from the abstract DI misconception only, but this patch does not feel good to me overall, too.

    AbstractNode.php:69 Unresolved

    abstracts must not pollute __construct() since that forces inheriting classes to know DI args of the abstract since they need to call parent and then must know the arguments, which creates API core should not introduce since that's close to impossible to maintain without being breaking.
  6. Sybille Peters uploaded patch set 3 V -1 05/26/24, 09:27

  7. Sybille Peters uploaded patch set 4 05/26/24, 09:27

  8. Sybille Peters commented on patch set 4 05/26/24, 09:29

    Reply

    So you have an alternative suggestion? I explained in the issue that is is not possible to use XCLASS for abstract classes. I will abandon patch.
  9. Sybille Peters abandoned the change 05/26/24, 09:30

    See comments: too big hammer for a too small problem. it's also not how formEngine is supposed to work