Review main Merged

84405[TASK] Avoid useless readonly in SiteSettingsFactory

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 05/26/24, 09:53

Commit message

Full class is set readonly, no need to set it
for a single constructor argument.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Torben Hansen +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Torben Hansen +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 67

  1. Christian Kuhn uploaded patch set 1 05/26/24, 09:15

  2. core-ci voted on patch set 1 V +1 05/26/24, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58256

  3. Stefan Bürk voted on patch set 1 CR +1 V +1 05/26/24, 09:31

  4. Oliver Klee voted on patch set 1 CR +1 V +1 05/26/24, 09:45

  5. Torben Hansen voted on patch set 1 CR +1 V +1 05/26/24, 09:46

  6. Stefan Bürk voted on patch set 1 CR +2 V +2 05/26/24, 09:53

  7. Stefan Bürk merged patch set 2 05/26/24, 09:53