Review main Merged

84407[BUGFIX] Do not forcibly add softhyphen toolbar item in CKEditor

Torben Hansen CR +2 V +2 Normal +29 −96 updated 07/12/24, 06:02

Commit message

When a CKEditor configuration by intention does not include the
`softhyphen` toolbar item, the item is automatically added in
`CKEditor5Migrator`.

This change removes the forcibly added softhyphen toolbar item,
allowing integrators to create a CKEditor configuration that does
not include the `softhyphen` toolbar item.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 68

  1. Torben Hansen uploaded patch set 1 05/26/24, 10:35

  2. core-ci voted on patch set 1 V -1 05/26/24, 10:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58266

  3. Torben Hansen uploaded patch set 2 V -1 05/26/24, 11:05

  4. core-ci voted on patch set 2 V +1 05/26/24, 11:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58270

  5. Garvin Hicking commented on patch set 2 CR +1 V +1 06/14/24, 07:40

    I have an uncozy feeling somehow with all this softhyphen related configuration and whitespace plugin "conflicts", but I'm leaning towards believing this should be right.
  6. Georg Ringer voted on patch set 2 CR +1 V +1 06/26/24, 04:09

  7. Benni Mack voted on patch set 2 CR +2 V +2 07/12/24, 06:01

  8. Benni Mack merged patch set 3 07/12/24, 06:02