Review main Merged

84408[BUGFIX] Stabilize SimpleLockStrategyTest

Christian Kuhn CR +2 V +2 Easy +2 −1 updated 05/26/24, 12:26

Commit message

With `@touch()` being changed to `touch()` with #103911,
its now clear the random fail stems from the test not being
able to create the file sometimes:

touch(): Unable to create file
/builds/typo3/CI/cms/typo3temp/var/lock/../../var/lock/foo
because No such file or directory

This also explains why it happens in unitRandom on CI only:
Usually this test is run after some previous test created
typo3temp already, with unitRandom it may be rejuggled so
typo3temp does not exist yet. Also, local machines typically
have this directory after a first unit test run, which is why
the test fails on CI only, since CI always starts with a
'git clean' directory state.

The patch changes the test to make sure the directory path
is created before the fixture file is touched.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 68

  1. Christian Kuhn uploaded patch set 1 05/26/24, 11:41

  2. Anja Leichsenring updated the commit message in patch set 2 05/26/24, 11:43

  3. Anja Leichsenring voted on patch set 2 CR +1 V +1 05/26/24, 11:44

  4. core-ci voted on patch set 1 V +1 05/26/24, 11:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58273

  5. core-ci voted on patch set 2 V +1 05/26/24, 11:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58274

  6. Stefan Bürk voted on patch set 2 CR +1 V +1 05/26/24, 12:16

  7. Anja Leichsenring voted on patch set 2 CR +2 V +2 05/26/24, 12:26

  8. Anja Leichsenring merged patch set 3 05/26/24, 12:26