Review main Merged

84409[TASK] Activate two skipped unit tests

Christian Kuhn CR +2 V +2 Easy +13 −13 updated 05/26/24, 12:41

Commit message

Two unit tests are skipped since they try to verify
correct behavior while the system under test returns
something broken or not implemented.

The patch activates the tests to document the broken
behavior and adds `@todo` annotations explaining what
is going wrong or should be expected.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 79

  1. Christian Kuhn uploaded patch set 1 05/26/24, 12:13

  2. Anja Leichsenring voted on patch set 1 CR +1 V +1 05/26/24, 12:18

  3. core-ci voted on patch set 1 V -1 05/26/24, 12:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58277

  4. Christian Kuhn uploaded patch set 2 CR +1 V +1 05/26/24, 12:21

  5. Anja Leichsenring voted on patch set 2 CR +1 V +1 05/26/24, 12:26

  6. core-ci voted on patch set 2 V +1 05/26/24, 12:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58278

  7. Stefan Bürk voted on patch set 2 CR +1 V +1 05/26/24, 12:29

  8. Christian Kuhn voted on patch set 2 CR +2 V +2 05/26/24, 12:41

  9. Christian Kuhn merged patch set 3 05/26/24, 12:41