Review main Merged

84410[BUGFIX] Avoid 4th argument on GU::callUserFunction() in test

Christian Kuhn CR +2 V +2 Easy +1 −11 updated 05/26/24, 13:15

Commit message

GeneralUtility::callUserFunction() has only three
parameters, as detected by phpstan.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 58

  1. Christian Kuhn uploaded patch set 1 05/26/24, 12:39

  2. core-ci voted on patch set 1 V -1 05/26/24, 12:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58279

  3. core-ci commented on patch set 1 05/26/24, 12:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58279

  4. core-ci voted on patch set 1 V +1 05/26/24, 13:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58279

  5. Stefan Bürk voted on patch set 1 CR +1 V +1 05/26/24, 13:04

  6. Anja Leichsenring voted on patch set 1 CR +1 V +1 05/26/24, 13:06

  7. Christian Kuhn voted on patch set 1 CR +2 V +2 05/26/24, 13:15

  8. Christian Kuhn merged patch set 2 05/26/24, 13:15