Review main Merged

84412[BUGFIX] Avoid broken assertion in ExtensionRepositoryTest

Christian Kuhn CR +2 V +2 Easy +1 −6 updated 05/26/24, 13:33

Commit message

$this->count() in phpunit always returns 1 and has no arguments
as correctly found by phpstan. Fix a test to actually assert
subject result count.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 68

  1. Christian Kuhn uploaded patch set 1 05/26/24, 13:14

  2. Christian Kuhn updated the commit message in patch set 2 05/26/24, 13:16

  3. Anja Leichsenring voted on patch set 2 CR +1 V +1 05/26/24, 13:19

  4. core-ci voted on patch set 1 V +1 05/26/24, 13:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58281

  5. core-ci voted on patch set 2 V +1 05/26/24, 13:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58282

  6. Stefan Bürk voted on patch set 2 CR +1 V +1 05/26/24, 13:28

  7. Christian Kuhn voted on patch set 2 CR +2 V +2 05/26/24, 13:33

  8. Christian Kuhn merged patch set 3 05/26/24, 13:33