Review main Merged

84415[TASK] Avoid implicitly nullable parameter on `DatabaseRecordException`

Stefan Bürk CR +2 V +2 Easy +5 −3 updated 05/27/24, 12:24

Commit message

With PHP 8.4 marking method parameter implicitly nullable
is depreacted and will emit a `E_DEPRECATED` warning. One
recommended way to resolve this, is making it explicitly
nullable using the `?` nullable operator. [1]

In cases, where are implicitly nullable parameter exists
before not-nullable parameters in a method or constructor,
making it explicitly nullable will emit a

  Optional parameter <paramname> declared before required
  parameter <paramname> is implicitly treated as a required
  parameter

since PHP 8.0 [2].

This change removes the `null` default value and adds the `?`
nullable operator to the previousException parameter for the
`\TYPO3\CMS\Backend\Form\Exception\DatabaseRecordException`
constructor.

This prepares the way towards PHP 8.4 compatibility.

[1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated
[2] https://php.watch/versions/8.0/deprecate-required-param-after-optional

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 913

  1. Stefan Bürk uploaded patch set 1 05/26/24, 20:24

  2. Stefan Bürk uploaded patch set 2 05/26/24, 20:28

  3. core-ci voted on patch set 2 V +1 05/26/24, 20:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58290

  4. core-ci voted on patch set 1 V -1 05/26/24, 20:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58289

  5. Stefan Bürk uploaded patch set 3 V +1 05/27/24, 10:36

  6. core-ci voted on patch set 3 V +1 05/27/24, 10:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58335

  7. Oliver Klee voted on patch set 3 CR +1 V +1 05/27/24, 10:48

  8. Christian Kuhn updated the commit message in patch set 4 CR +1 V +1 05/27/24, 12:06

  9. Oliver Klee voted on patch set 4 CR +1 V +1 05/27/24, 12:08

  10. Christian Kuhn voted on patch set 4 CR +1 V +1 05/27/24, 12:09

  11. core-ci voted on patch set 4 V +1 05/27/24, 12:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58337

  12. Stefan Bürk voted on patch set 4 CR +2 V +2 05/27/24, 12:11

  13. Stefan Bürk merged patch set 5 05/27/24, 12:24