84416[TASK] Avoid implicitly nullable class method parameter
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Benjamin Franzke +1
- Oliver Klee +1
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Benjamin Franzke +1
- Oliver Klee +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1013
-
Stefan Bürk uploaded patch set 1 05/26/24, 20:58
-
core-ci voted on patch set 1 V +1 05/26/24, 21:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58291
-
Stefan Bürk uploaded patch set 2
V +105/26/24, 21:21 -
core-ci voted on patch set 2 V -1 05/26/24, 21:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58296
-
Benjamin Franzke commented on patch set 2 CR -1 05/27/24, 08:16
FileStorageIndexingAdditionalFieldProvider.php:63why is this now passed by reference? -
Stefan Bürk uploaded patch set 3
CR -1V -105/27/24, 10:23 -
Stefan Bürk commented on patch set 3 05/27/24, 10:23
FileStorageIndexingAdditionalFieldProvider.php:63ReplyAdopted from calling method. Call by reference not needed here, ack.FileStorageIndexingAdditionalFieldProvider.php:63ReplyForgot to add the nullable operator `?`. However, changed to your suggestion. -
core-ci voted on patch set 3 V +1 05/27/24, 10:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58334
-
Oliver Klee voted on patch set 3 CR +1 V +1 05/27/24, 10:34
-
Benjamin Franzke voted on patch set 3 CR +1 V +1 05/27/24, 12:07
-
Christian Kuhn voted on patch set 3 CR +1 V +1 05/27/24, 12:11
-
Stefan Bürk voted on patch set 3 CR +2 V +2 05/27/24, 12:17
-
Stefan Bürk merged patch set 4 05/27/24, 12:52
FileStorageIndexingAdditionalFieldProvider.php:63