Review main Merged

84417[TASK] Increase SUFFIX uniqueness in `runTests.sh` for CI

Stefan Bürk CR +2 V +2 Easy +8 −2 updated 07/19/24, 11:49

Commit message

This change adds the predefined GitLab CI/CD variable
`CI_JOB_ID` value to the suffix, used for containerized
network and container names, with the goal to increase
uniqueness in CI runs.

Additionally, the value is now displayed in execution
and the container cleanup notes at least the network
name further information source to investage unusually
container shutdowns.

[1] https://docs.gitlab.com/ee/ci/variables/predefined_variables.html

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 1218

  1. Stefan Bürk uploaded patch set 1 05/26/24, 21:15

  2. Stefan Bürk updated the commit message in patch set 2 05/26/24, 21:16

  3. Stefan Bürk updated the commit message in patch set 3 05/26/24, 21:16

  4. Stefan Bürk uploaded patch set 4 05/26/24, 21:18

  5. core-ci voted on patch set 2 V -1 05/26/24, 21:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58293

  6. core-ci voted on patch set 1 V +1 05/26/24, 21:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58292

  7. core-ci voted on patch set 3 V -1 05/26/24, 21:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58294

  8. core-ci voted on patch set 4 V -1 05/26/24, 21:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58295

  9. Stefan Bürk voted on patch set 4 CR -2 05/27/24, 10:50

  10. core-ci voted on patch set 4 V +1 05/27/24, 10:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58295

  11. Stefan Bürk voted on patch set 4 CR 0 05/27/24, 12:31

  12. Christian Kuhn commented on patch set 4 CR -1 05/27/24, 12:47

    let's wait on this a bit, and have a chat, stefan.
  13. Stefan Bürk abandoned the change 06/05/24, 14:49

    Abandon for now - not needed.
  14. Stefan Bürk restored the change 07/19/24, 11:12

  15. Stefan Bürk rebased onto patch set 5 CR -1 V +1 07/19/24, 11:15

  16. core-ci voted on patch set 5 V +1 07/19/24, 11:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61803

  17. Christian Kuhn commented on patch set 5 CR +2 V +2 07/19/24, 11:49

    we will merge this now to increase CI bug hunting chances.
  18. Christian Kuhn merged patch set 6 07/19/24, 11:49