Review 12.4 Merged

84422[TASK] Remove `doctrine/dbal` version aware method mocking in tests

Christian Kuhn CR +2 V +2 Easy +8 −26 updated 05/27/24, 09:27

Commit message

`\TYPO3\CMS\Core\Tests\Unit\Database\ConnectionTest` containes
code to mock Connection methods conditionally, based on their
existance surrounded by a `@todo` comment to remove this, when
`doctrine/dbal` has been required with 2.11.0 as minimal version.

The version raise has been done already a long time ago, however
the removal of this conditional test mock has been missed.

This change removes the conditional mocking now.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 35

  1. Christian Kuhn uploaded patch set 1 05/27/24, 08:59

  2. core-ci voted on patch set 1 V -1 05/27/24, 09:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58330

  3. core-ci voted on patch set 1 V +1 05/27/24, 09:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58330

  4. Christian Kuhn voted on patch set 1 CR +2 V +2 05/27/24, 09:27

  5. Christian Kuhn merged patch set 2 05/27/24, 09:27