84426[BUGFIX] Avoid exceptions due to non-HTTP URI values in CSP reporter
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Georg Ringer +1
- Garvin Hicking +1
-
Verified V +2 Done
- Christian Kuhn +2
- Georg Ringer +1
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1823
-
Georg Ringer uploaded patch set 1 05/27/24, 17:55
-
Georg Ringer commented on patch set 1 05/27/24, 17:55
This change is ready for review. -
core-ci voted on patch set 1 V -1 05/27/24, 18:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58351
-
Georg Ringer uploaded patch set 2
V -105/27/24, 20:27 -
core-ci voted on patch set 2 V +1 05/27/24, 20:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58353
-
Oliver Hader commented on patch set 2 CR -1 06/13/24, 08:18
On it.. -
Oliver Hader uploaded patch set 3
CR -1V +106/13/24, 08:53 -
core-ci voted on patch set 3 V +1 06/13/24, 09:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59434
-
Garvin Hicking commented on patch set 3 CR +1 V +1 06/13/24, 09:04
Thank you! I think this is a good solution without needing specific exemptions :-) -
Mathias Brodala commented on patch set 3 CR -1 07/03/24, 07:52
Uri.php:112IMO we should avoid prehistoric concepts like bitwise options/flags and embrace more modern approaches instead: - use a literal named argument, e.g. $anyScheme - use an array or variadic argument of options, use an enum within - use an additional named constructor like Uri::fromAnyScheme($uri) - maybe more -
Oliver Hader commented on patch set 3 07/03/24, 09:36
Uri.php:112ReplyThanks for your feedback. I personally dislike multiple/variadic options and default argument values... However, the static factory method `fromAnyScheme($uri)` seems to be a good compromise, that's a good idea, thanks! 👍 -
Oliver Hader uploaded patch set 4
CR +1V +107/03/24, 12:02 -
Oliver Hader commented on patch set 4 07/03/24, 12:03
Uri.php:112ReplyDone -
core-ci voted on patch set 4 V +1 07/03/24, 12:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60903
-
Garvin Hicking commented on patch set 4 CR +1 V +1 07/03/24, 12:34
Cool, that's easier to read, thanks! :) -
Oliver Hader commented on patch set 4 CR -1 07/04/24, 06:15
Small adjustment... -
Oliver Hader uploaded patch set 5
CR +1V +107/04/24, 06:22 -
core-ci voted on patch set 5 V +1 07/04/24, 06:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60948
-
Oliver Hader wrote 07/04/24, 08:27
Topic set to csp -
Garvin Hicking voted on patch set 5 CR +1 V +1 07/12/24, 08:38
-
Georg Ringer voted on patch set 5 CR +1 V +1 08/02/24, 11:56
-
Christian Kuhn voted on patch set 5 CR +2 V +2 08/06/24, 10:05
-
Christian Kuhn merged patch set 6 08/06/24, 10:12