84427[BUGFIX] Do not fail on link generation in backend context
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Torben Hansen +1
-
Verified V +2 Done
- Oli Bartsch +2
- Torben Hansen +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1723
-
Georg Ringer uploaded patch set 1 05/27/24, 20:11
-
Georg Ringer commented on patch set 1 05/27/24, 20:12
This change is ready for review. -
core-ci voted on patch set 1 V -1 05/27/24, 20:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58352
-
Georg Ringer uploaded patch set 2
V -105/27/24, 20:28 -
core-ci voted on patch set 2 V +1 05/27/24, 20:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58354
-
Torben Hansen voted on patch set 2 CR +1 V +1 05/28/24, 17:33
-
Stefan Bürk commented on patch set 2 05/28/24, 23:45
DatabaseRecordLinkBuilder.php:132Don't we miss the full rootline in that case, specially if it is not in the runtime cache ? -
Georg Ringer commented on patch set 2 05/29/24, 04:46
we will for sure miss information but there is not even a page id to build a rootline in the backend and just using the BE domain to retrieve e.g. the 1st site is not an option either :/ -
Torben Hansen commented on patch set 2 06/01/24, 09:29
Reply
Maybe this https://github.com/TYPO3/typo3/blob/main/typo3/sysext/frontend/Classes/Typolink/AbstractTypolinkBuilder.php#L196 is the missing brick here (expecially the part with TypoLink and backend context). Since we in v13 can not use TSFE->id any more, the whole TSFE fallback logic for backend context in `AbstractTypolinkBuilder` can maybe be removed. But in general, this patch look good to me. -
Georg Ringer rebased onto patch set 3
CR +1V +112/18/24, 11:50 -
Oli Bartsch updated the commit message in patch set 4 12/18/24, 11:51
-
Benni Mack commented on patch set 4 12/18/24, 11:53
DatabaseRecordLinkBuilder.php:132Replyin BE you don't have it, so we take the root page of the site, whereas on the rootlevel this is just the one page record anyways, I assume. -
core-ci voted on patch set 3 V +1 12/18/24, 11:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71372
-
core-ci voted on patch set 4 V +1 12/18/24, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71373
-
Oli Bartsch uploaded patch set 5
V +112/18/24, 12:08 -
Oli Bartsch voted on patch set 5 CR +1 V +1 12/18/24, 12:08
-
core-ci voted on patch set 5 V -1 12/18/24, 12:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71374
-
Torben Hansen uploaded patch set 6
CR +1V +112/18/24, 12:25 -
Torben Hansen voted on patch set 6 CR +1 V +1 12/18/24, 12:26
-
core-ci voted on patch set 6 V +1 12/18/24, 12:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71377
-
Oli Bartsch voted on patch set 6 CR +1 V +1 12/18/24, 12:44
-
Oli Bartsch commented on patch set 6 CR +2 V +2 12/18/24, 14:26
Reply
DoneDatabaseRecordLinkBuilder.php:132ReplyDone -
Oli Bartsch merged patch set 7 12/18/24, 14:26