Review 11.5 Merged

84437[BUGFIX] Perform is_dir without trailing slash

Benjamin Franzke CR +2 V +2 Easy +3 −3 updated 06/05/24, 15:02

Commit message

Workaround a PHP issue which will produce an open_basedir
restriction warning if `is_dir()` is used on a regular file
when the trailing slash is provided.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Benjamin Franzke uploaded patch set 1 05/28/24, 10:22

  2. core-ci voted on patch set 1 V +1 05/28/24, 10:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58389

  3. Benjamin Franzke marked it work in progress 05/30/24, 07:16

  4. Benjamin Franzke commented on patch set 1 CR +2 V +2 06/05/24, 15:02

    This change is ready for review.
  5. Benjamin Franzke merged patch set 2 06/05/24, 15:02