Review main Merged

84438[FEATURE] Introduce `lint:yaml` command

Stefan Bürk CR +2 V +2 Easy +41 −0 updated 09/15/24, 11:12

Commit message

The `symfony/yaml` package is a hard dependency of the
TYPO3 Core and ships a dedicated `yaml-lint` binary as
entry point for the shipped `LintCommand` class.

Most TYPO3 integrators and developers are not aware of
that dedicated binary installed along the way and only
know about the TYPO3 binary for command execution. As
the TYPO3 core relies on YAML files and parsing with an
increasing number of implementation and use cases it's
good to have linting of these files in available and easy to reach.

This change adds the `symfony/yaml` linting command to
the TYPO3 binary as feature with corresponding raise
of awareness, albeit being a development and pipeline
support feature only.

The new command can be used from the TYPO3 binary with:

  bin/typo3 lint:yaml
  bin/typo3 lint:yaml --help

directly in composer and non-composer installations.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Guido Schmechel +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Guido Schmechel +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 710

  1. Stefan Bürk uploaded patch set 1 05/28/24, 10:26

  2. core-ci voted on patch set 1 V +1 05/28/24, 10:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58391

  3. Stefan Bürk rebased onto patch set 2 V +1 09/15/24, 04:35

  4. core-ci voted on patch set 2 V +1 09/15/24, 04:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65794

  5. Anja Leichsenring uploaded patch set 3 V +1 09/15/24, 09:59

  6. Anja Leichsenring voted on patch set 3 CR +1 V +1 09/15/24, 10:00

  7. core-ci voted on patch set 3 V +1 09/15/24, 10:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65803

  8. Guido Schmechel voted on patch set 3 CR +1 V +1 09/15/24, 10:48

  9. Anja Leichsenring voted on patch set 3 CR +2 V +2 09/15/24, 11:12

  10. Anja Leichsenring merged patch set 4 09/15/24, 11:12