Review main Merged

84439[TASK] Update less class state in TypoScript tokenizers

Christian Kuhn CR +2 V +2 Normal +50 −49 updated 05/28/24, 13:59

Commit message

Detail methods of the two TypoScript tokenizers tend
to add mental load since they often update `$this`
state.

The patch changes `splitLines()` and `parseValueForConstants()`
to return updated things instead, for consuming methods
to take care of this.

This is a pre-patch to simplify #102742.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 79

  1. Christian Kuhn uploaded patch set 1 05/28/24, 13:07

  2. core-ci voted on patch set 1 V +1 05/28/24, 13:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58397

  3. Oliver Klee updated the commit message in patch set 2 V +1 05/28/24, 13:17

  4. Oliver Klee voted on patch set 2 V +1 05/28/24, 13:21

  5. Oliver Klee voted on patch set 2 CR +1 05/28/24, 13:21

  6. core-ci voted on patch set 2 V +1 05/28/24, 13:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58399

  7. Stefan Bürk voted on patch set 2 CR +1 V +1 05/28/24, 13:37

  8. Christian Kuhn voted on patch set 2 CR +2 V +2 05/28/24, 13:59

  9. Christian Kuhn merged patch set 3 05/28/24, 13:59