Review 12.4 Merged

84440[TASK] Update less class state in TypoScript tokenizers

Christian Kuhn CR +2 V +2 Normal +50 −49 updated 05/28/24, 13:59

Commit message

Detail methods of the two TypoScript tokenizers tend
to add mental load since they often update `$this`
state.

The patch changes `splitLines()` and `parseValueForConstants()`
to return updated things instead, for consuming methods
to take care of this.

This is a pre-patch to simplify #102742.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 34

  1. Christian Kuhn uploaded patch set 1 05/28/24, 13:38

  2. core-ci voted on patch set 1 V +1 05/28/24, 13:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58404

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 05/28/24, 13:59

  4. Christian Kuhn merged patch set 2 05/28/24, 13:59