Review main Merged

84442[BUGFIX] Resolve falsy ENV-variables in YAML Site Configuration values

Garvin Hicking CR +2 V +2 Normal +57 −6 updated 09/06/25, 01:19

Commit message

Using '%env(SOME_VARIABLE)%' within a site configuration YAML
did not resolve contents in SOME_VARIABLE that were
falsy ('false', '0', 0).

This patch now properly converts those falsy values to actual
values.

Tests are added to verify the new behavior and prevent
future regressions. Drive-by fix on Unit tests which did
not actually remove env vars after testing, putenv('var')
is needed instead of putenv('var='), because the latter
will keep the environment var around (with an empty value).

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Markus Klein +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Markus Klein +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1113

  1. Garvin Hicking uploaded patch set 1 05/28/24, 15:33

  2. core-ci voted on patch set 1 V -1 05/28/24, 15:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58411

  3. Garvin Hicking uploaded patch set 2 V -1 05/28/24, 15:57

    Adjust commit message and properly use putenv
  4. core-ci voted on patch set 2 V +1 05/28/24, 16:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58412

  5. Oliver Klee voted on patch set 2 V +1 05/28/24, 20:26

  6. Oliver Klee voted on patch set 2 CR +1 05/28/24, 20:26

  7. Georg Ringer voted on patch set 2 CR +1 V +1 05/28/24, 20:39

  8. Markus Klein voted on patch set 2 CR +1 V +1 05/28/24, 20:49

  9. Oliver Hader voted on patch set 2 CR +1 05/29/24, 05:47

  10. Stefan Bürk commented on patch set 2 CR -1 05/29/24, 07:18

    reviewing ...
  11. Stefan Bürk voted on patch set 2 CR +2 V +2 05/29/24, 07:37

  12. Stefan Bürk merged patch set 3 05/29/24, 08:09

  13. Stefan Bürk commented on patch set 3 09/06/25, 01:19

    Reply

    Done