84442[BUGFIX] Resolve falsy ENV-variables in YAML Site Configuration values
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Georg Ringer +1
- Oliver Klee +1
- Markus Klein +1
- Oliver Hader +1
-
Verified V +2 Done
- Stefan Bürk +2
- Georg Ringer +1
- Oliver Klee +1
- Markus Klein +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/core/Classes/Configuration/Processor/Placeholder/EnvVariableProcessor.php+1 −1
- typo3/sysext/core/Tests/Functional/Configuration/Loader/Fixtures/Env/NullAndFalse.yamlnew+9 −0
- typo3/sysext/core/Tests/Functional/Configuration/Loader/YamlFileLoaderTest.php+44 −2
- typo3/sysext/core/Tests/Unit/Configuration/Loader/YamlFileLoaderTest.php+3 −3
Review log 1113
-
Garvin Hicking uploaded patch set 1 05/28/24, 15:33
-
core-ci voted on patch set 1 V -1 05/28/24, 15:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58411
-
Garvin Hicking uploaded patch set 2
V -105/28/24, 15:57Adjust commit message and properly use putenv -
core-ci voted on patch set 2 V +1 05/28/24, 16:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58412
-
Oliver Klee voted on patch set 2 V +1 05/28/24, 20:26
-
Oliver Klee voted on patch set 2 CR +1 05/28/24, 20:26
-
Georg Ringer voted on patch set 2 CR +1 V +1 05/28/24, 20:39
-
Markus Klein voted on patch set 2 CR +1 V +1 05/28/24, 20:49
-
Oliver Hader voted on patch set 2 CR +1 05/29/24, 05:47
-
Stefan Bürk commented on patch set 2 CR -1 05/29/24, 07:18
reviewing ... -
Stefan Bürk voted on patch set 2 CR +2 V +2 05/29/24, 07:37
-
Stefan Bürk merged patch set 3 05/29/24, 08:09
-
Stefan Bürk commented on patch set 3 09/06/25, 01:19
Reply
Done