Review main Merged

84444[BUGFIX] Make DebuggerUtility UTF-8 aware for substring splitting

Garvin Hicking CR +2 V +2 Normal +123 −4 updated 06/03/24, 07:47

Commit message

The current implementation does not properly split UTF-8 formatted
strings into multi-lines.

This patch now utilizes the corresponding mb_* PHP functions to ensure
proper splitting.

Tests are added to verify this behaviour.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 79

  1. Garvin Hicking uploaded patch set 1 05/29/24, 15:02

  2. core-ci voted on patch set 1 V +1 05/29/24, 15:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58450

  3. Oliver Klee voted on patch set 1 CR +1 V +1 05/29/24, 15:59

  4. Benjamin Franzke voted on patch set 1 CR +2 V +2 05/30/24, 10:28

  5. Benjamin Franzke uploaded patch set 2 CR +1 V +1 05/31/24, 06:45

  6. core-ci voted on patch set 2 V +1 05/31/24, 06:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58524

  7. Stefan Bürk voted on patch set 2 CR +1 V +1 06/03/24, 07:45

  8. Benjamin Franzke voted on patch set 2 CR +2 V +2 06/03/24, 07:47

  9. Benjamin Franzke merged patch set 3 06/03/24, 07:47