Review main Merged

84447[TASK] Prepare import map prefix-based URL calculation

Benjamin Franzke CR +2 V +2 Easy +22 −1 updated 03/05/25, 08:20

Commit message

Import map resolution without a cache-bust suffix missed to join a
previously splitted path-string via slashes, when a prefix based
import-declaration was used to calculate the resulting URL of a
JavaScript bare module specifier (usecase: calculate the
URL of a bare module specifier for usage in a `<script src="">`
tag, where bare module specifiers like `@typo3/backend/foo.js` can
not be used directly as browsers will not map them by importmap).

Note: TYPO3 currently uses cache-bust suffixes only, as there
are no cache-bust prefixes yet. Therefore all prefix-paths are
recursively pre-calculated in `computeImportMaps()`, which effecively
skipped the broken codepath for the current environments, which means
this is a preparatory TASK and not a BUGFIX for the case when
once prefix-based cache-busting is added in #98481.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1319

  1. Benjamin Franzke uploaded patch set 1 05/30/24, 06:49

  2. core-ci voted on patch set 1 V +1 05/30/24, 06:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58475

  3. Benjamin Franzke wrote 05/30/24, 07:18

    Topic set to esm
  4. Stefan Bürk updated the commit message in patch set 2 V +1 05/30/24, 10:25

  5. core-ci voted on patch set 2 V +1 05/30/24, 10:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58484

  6. Georg Ringer voted on patch set 2 CR +1 V +1 05/30/24, 19:58

  7. Benni Mack updated the commit message in patch set 3 CR +1 V +1 10/18/24, 13:31

  8. core-ci voted on patch set 3 V -1 10/18/24, 22:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67986

  9. core-ci commented on patch set 3 10/22/24, 05:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67986

  10. Benni Mack rebased onto patch set 4 V -1 10/22/24, 06:22

  11. core-ci voted on patch set 4 V +1 10/22/24, 06:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68351

  12. Benjamin Franzke marked it work in progress 12/19/24, 09:29

  13. Benjamin Franzke uploaded patch set 5 V +1 03/05/25, 07:21

  14. core-ci voted on patch set 5 V +1 03/05/25, 07:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75141

  15. Andreas Kienast voted on patch set 5 CR +1 03/05/25, 07:43

  16. Andreas Kienast voted on patch set 5 V +1 03/05/25, 07:50

  17. Benjamin Kott voted on patch set 5 CR +1 V +1 03/05/25, 07:52

  18. Benjamin Franzke voted on patch set 5 CR +2 V +2 03/05/25, 07:52

  19. Benjamin Franzke merged patch set 6 03/05/25, 08:20