Review main Merged

84449[TASK] Remove unneeded `$siteMockRevelation` in SiteResolvingTest

Andreas Kienast CR +2 V +2 Easy +4 −6 updated 05/31/24, 06:43

Commit message

With migration away from prophecy during v12 development, the variable
`$siteMockRevelation` is not needed anymore as phpunit mocks don't know
the concept of revelations.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Kevin Appelt +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Andreas Kienast uploaded patch set 1 05/31/24, 06:25

  2. Anja Leichsenring voted on patch set 1 CR +1 V +1 05/31/24, 06:27

  3. core-ci voted on patch set 1 V +1 05/31/24, 06:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58519

  4. Kevin Appelt voted on patch set 1 CR +1 05/31/24, 06:37

  5. Oli Bartsch voted on patch set 1 CR +2 V +2 05/31/24, 06:43

  6. Oli Bartsch merged patch set 2 05/31/24, 06:43