Review main Merged

84450[DOCS] Add details to "Trusted Host Pattern" installer warning message

Garvin Hicking CR +2 V +2 Easy +3 −2 updated 06/05/24, 14:21

Commit message

The TYPO3 Contribution Guide lists DDEV as an easy way to get
started with a TYPO3-Core legacy-based installation.

The installation itself shows a big warning for the "Trusted Host
Pattern" mismatch when utilizing https:// for the installation,
which many people might do.

While the Contribution Guide mentions this as a sidenote,
the actual warning can be improved to better reflect the
reason and solution.

(Note that the installation can actually continue even
with this error, but may hint people at this being an
installation show-stopper, so it is now stated clearer,
that a working host pattern will be actually set and should
be adjusted after installation is complete)

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jonas Eberle +1
    • Lina Wolf +1
    • Mathias Bolt Lesniak +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jonas Eberle +1
    • Lina Wolf +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 1315

  1. Garvin Hicking uploaded patch set 1 05/31/24, 09:57

  2. core-ci voted on patch set 1 V +1 05/31/24, 10:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58529

  3. Mathias Bolt Lesniak commented on patch set 1 05/31/24, 10:23

    SetupCheck.php:88

    I think this can be shortened to something like: 'If the mismatch is caused by SSL routing, accessing the installation without SSL at http://’ . $_SERVER['HTTP_HOST'] . ' may correctly auto-configure the host pattern.'
  4. Garvin Hicking commented on patch set 1 05/31/24, 10:26

    SetupCheck.php:88 Reply

    I try to be not be too specific for SSL only because I think other possible proxy configurations leading to different hostnames of the internal HTTP_HOST could lead to the same issue. I also wanted to drop the "DDEV" buzzword because that would maybe trigger people to notice "Ah, that's what I use". If I just say "SSL routing" some people might bail out with their toughts and not understand what applies to them...? Otherwise I'm very happy for alternate wording suggestions, I just want people's brainbulbs to light up when reading the message, so they know what to do in their specific case :-)
  5. Jonas Eberle commented on patch set 1 05/31/24, 10:32

    It is helpful that it shows that this is not a hard error. But I think the last sentence (switch to http://) is not necessary and maybe misleading (auto-configure?).
  6. Mathias Bolt Lesniak commented on patch set 1 05/31/24, 10:48

    SetupCheck.php:88 Reply

    Since this is a flash message, it should ideally not be too long. Maybe it would be an idea to add the possibility for a "View documentation" button for flash messages and an optional parameter for adding a link?
  7. Garvin Hicking commented on patch set 1 05/31/24, 11:37

    SetupCheck.php:88 Reply

    IIRC flash messages don't support HTML so this would be a larger endeavour and harder to inplement. I'll sleep on this and will try to reduce the number of words somehow, while keeping the SSL&Proxy&DDEV buzzwords
  8. Garvin Hicking uploaded patch set 2 V +1 06/03/24, 07:11

    Adjust message
  9. Garvin Hicking commented on patch set 2 06/03/24, 07:12

    Reply

    Done
    @mathias.bolt.lesniak@typo3.org @flightvision@googlemail.com I've shortened this now and hopefully the reword mentioning ddev, SSL and proxy is okay like this. IMO it's an improvement compared to the current situation...?

    SetupCheck.php:88 Reply

    Done
  10. core-ci voted on patch set 2 V +1 06/03/24, 07:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58608

  11. Jonas Eberle voted on patch set 2 CR +1 V +1 06/03/24, 07:28

  12. Lina Wolf commented on patch set 2 CR +1 V +1 06/04/24, 15:50

    I think this change is helpfull
  13. Mathias Bolt Lesniak voted on patch set 2 CR +1 06/05/24, 07:43

  14. Christian Kuhn voted on patch set 2 CR +2 V +2 06/05/24, 14:21

  15. Christian Kuhn merged patch set 3 06/05/24, 14:21