84450[DOCS] Add details to "Trusted Host Pattern" installer warning message
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Jonas Eberle +1
- Lina Wolf +1
- Mathias Bolt Lesniak +1
-
Verified V +2 Done
- Christian Kuhn +2
- Jonas Eberle +1
- Lina Wolf +1
- core-ci +1 CI
Issues 3
- Bug #103959TYPO3 fresh installation in DDEV routing context fails on Trusted Hosts Pattern Mismatch
- Bug #88846Install tool (on FIRST_INSTALL) warns about "Trusted hosts pattern mismatch" although 'trustedHostsPattern' is set correctly (if no LocalConfiguration.php is present)
- Bug #86356Checking $GLOBALS['TYPO3_CONF_VARS']['SYS']['trustedHostsPattern'] should be disabled when running initial setup wizard
Files 1
Review log 1315
-
Garvin Hicking uploaded patch set 1 05/31/24, 09:57
-
core-ci voted on patch set 1 V +1 05/31/24, 10:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58529
-
Mathias Bolt Lesniak commented on patch set 1 05/31/24, 10:23
-
Garvin Hicking commented on patch set 1 05/31/24, 10:26
SetupCheck.php:88ReplyI try to be not be too specific for SSL only because I think other possible proxy configurations leading to different hostnames of the internal HTTP_HOST could lead to the same issue. I also wanted to drop the "DDEV" buzzword because that would maybe trigger people to notice "Ah, that's what I use". If I just say "SSL routing" some people might bail out with their toughts and not understand what applies to them...? Otherwise I'm very happy for alternate wording suggestions, I just want people's brainbulbs to light up when reading the message, so they know what to do in their specific case :-) -
Jonas Eberle commented on patch set 1 05/31/24, 10:32
It is helpful that it shows that this is not a hard error. But I think the last sentence (switch to http://) is not necessary and maybe misleading (auto-configure?). -
Mathias Bolt Lesniak commented on patch set 1 05/31/24, 10:48
SetupCheck.php:88ReplySince this is a flash message, it should ideally not be too long. Maybe it would be an idea to add the possibility for a "View documentation" button for flash messages and an optional parameter for adding a link? -
Garvin Hicking commented on patch set 1 05/31/24, 11:37
SetupCheck.php:88ReplyIIRC flash messages don't support HTML so this would be a larger endeavour and harder to inplement. I'll sleep on this and will try to reduce the number of words somehow, while keeping the SSL&Proxy&DDEV buzzwords -
Garvin Hicking uploaded patch set 2
V +106/03/24, 07:11Adjust message -
Garvin Hicking commented on patch set 2 06/03/24, 07:12
Reply
Done@mathias.bolt.lesniak@typo3.org @flightvision@googlemail.com I've shortened this now and hopefully the reword mentioning ddev, SSL and proxy is okay like this. IMO it's an improvement compared to the current situation...?SetupCheck.php:88ReplyDone -
core-ci voted on patch set 2 V +1 06/03/24, 07:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58608
-
Jonas Eberle voted on patch set 2 CR +1 V +1 06/03/24, 07:28
-
Lina Wolf commented on patch set 2 CR +1 V +1 06/04/24, 15:50
I think this change is helpfull -
Mathias Bolt Lesniak voted on patch set 2 CR +1 06/05/24, 07:43
-
Christian Kuhn voted on patch set 2 CR +2 V +2 06/05/24, 14:21
-
Christian Kuhn merged patch set 3 06/05/24, 14:21
SetupCheck.php:88