Review 12.4 Merged

84455[BUGFIX] Do not render nonceProxy if nonce has not been consumed

Benjamin Franzke CR +2 V +2 Easy +15 −5 updated 05/31/24, 08:05

Commit message

Allow proxies to cache the TYPO3 content by stripping the nonce from
the generated CSP header if the nonce was not actually consumed.

Also ensure that the nonce value substitution consumes a nonce
to ensure that a (replaced) nonces in cached-content receive
a matching CSP header as well.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 69

  1. Benjamin Franzke commented on patch set 1 05/30/24, 07:17

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 05/30/24, 07:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58476

  3. Benjamin Franzke marked it work in progress 05/30/24, 07:37

  4. Benjamin Franzke uploaded patch set 2 V +1 05/30/24, 09:16

  5. core-ci voted on patch set 2 V +1 05/30/24, 09:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58479

  6. Benjamin Franzke uploaded patch set 3 V +1 05/30/24, 10:18

  7. core-ci voted on patch set 3 V +1 05/30/24, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58482

  8. Benjamin Franzke commented on patch set 3 CR +2 V +2 05/31/24, 08:05

    This change is ready for review.
  9. Benjamin Franzke merged patch set 4 05/31/24, 08:05