Review main Merged

84472[TASK] Suppress phpstan error in GU::makeInstance

Anja Leichsenring CR +2 V +2 Easy +12 −7 updated 06/01/24, 13:14

Commit message

Phpstan claims the contract guard condition can never be true (in
which case an exception will be thrown) but this is not true. So
we keep the condition, but suppress the error.

PHPStan gets updated and pinned to lowest version 1.11.3
with

	composer require --dev phpstan/phpstan:^1.11.3

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Torben Hansen +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Torben Hansen +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 811

  1. Anja Leichsenring uploaded patch set 1 06/01/24, 11:58

  2. core-ci voted on patch set 1 V -1 06/01/24, 12:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58561

  3. Anja Leichsenring uploaded patch set 2 V -1 06/01/24, 12:12

  4. Anja Leichsenring commented on patch set 2 06/01/24, 12:19

  5. core-ci voted on patch set 2 V +1 06/01/24, 12:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58562

  6. Stefan Bürk updated the commit message in patch set 3 V +1 06/01/24, 12:21

  7. core-ci voted on patch set 3 V +1 06/01/24, 12:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58564

  8. Stefan Bürk voted on patch set 3 CR +1 V +1 06/01/24, 12:27

  9. Torben Hansen voted on patch set 3 CR +1 V +1 06/01/24, 13:01

  10. Anja Leichsenring voted on patch set 3 CR +2 V +2 06/01/24, 13:14

  11. Anja Leichsenring merged patch set 4 06/01/24, 13:14