Review 12.4 Merged

84473[TASK] Suppress phpstan error in GU::makeInstance

Anja Leichsenring CR +2 V +2 Easy +12 −7 updated 06/01/24, 13:15

Commit message

Phpstan claims the contract guard condition can never be true (in
which case an exception will be thrown) but this is not true. So
we keep the condition, but suppress the error.

PHPStan gets updated and pinned to lowest version 1.11.3
with

	composer require --dev phpstan/phpstan:^1.11.3

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
  • Verified V +2 Done
    • Anja Leichsenring +2
    • core-ci +1 CI

Issues 2

Files 3

Review log 46

  1. Anja Leichsenring uploaded patch set 1 06/01/24, 12:13

  2. Stefan Bürk updated the commit message in patch set 2 06/01/24, 12:21

  3. core-ci voted on patch set 1 V +1 06/01/24, 12:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58563

  4. core-ci voted on patch set 2 V +1 06/01/24, 12:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58565

  5. Anja Leichsenring voted on patch set 2 CR +2 V +2 06/01/24, 13:15

  6. Anja Leichsenring merged patch set 3 06/01/24, 13:15