84480[TASK] Add internal `Common Table Expression` support
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- Benni Mack +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 9
- typo3/sysext/core/Classes/Database/Query/ConcreteQueryBuilder.php+174 −0
- typo3/sysext/core/Classes/Database/Query/QueryBuilder.php+73 −0
- typo3/sysext/core/Classes/Database/Query/With.phpnew+70 −0
- typo3/sysext/core/Classes/Database/Query/WithCollection.phpnew+104 −0
- typo3/sysext/core/Tests/Functional/Database/Query/QueryBuilder/CommonTableExpression/Fixtures/CTE/recursiveCommonTableExpression_pageTreeOne.csv4new+12 −0
- typo3/sysext/core/Tests/Functional/Database/Query/QueryBuilder/CommonTableExpression/SimpleRootLineTraversalTest.phpnew+189 −0
- typo3/sysext/core/Tests/Functional/Database/Query/QueryBuilder/CommonTableExpression/SimpleSelectCommonTableExpressionTest.phpnew+518 −0
- typo3/sysext/core/Tests/Functional/Database/Query/QueryBuilder/CommonTableExpression/SimpleTreeTraversalTest.phpnew+288 −0
- typo3/sysext/core/Tests/Unit/Database/Query/WithCollectionTest.phpnew+95 −0
Review log 3156
Show 1731 earlier messages
-
Stefan Bürk uploaded patch set 1 06/03/24, 16:54
-
core-ci voted on patch set 1 V -1 06/03/24, 17:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58623
-
Stefan Bürk uploaded patch set 2
V -106/06/24, 13:25 -
Stefan Bürk uploaded patch set 3 06/06/24, 13:27
-
core-ci voted on patch set 2 V -1 06/06/24, 13:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58798
-
core-ci voted on patch set 3 V -1 06/06/24, 13:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58800
-
Stefan Bürk uploaded patch set 4
V -106/07/24, 10:11 -
core-ci voted on patch set 4 V -1 06/07/24, 10:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58868
-
Stefan Bürk uploaded patch set 5
V -106/07/24, 10:25 -
core-ci voted on patch set 5 V +1 06/07/24, 10:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58869
-
Stefan Bürk uploaded patch set 6
V +106/07/24, 12:02 -
core-ci voted on patch set 6 V +1 06/07/24, 12:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58875
-
Stefan Bürk uploaded patch set 7
V +106/07/24, 12:43 -
core-ci voted on patch set 7 V +1 06/07/24, 12:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58877
-
Stefan Bürk uploaded patch set 8
V +106/07/24, 15:49 -
core-ci voted on patch set 8 V +1 06/07/24, 15:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58882
-
Stefan Bürk uploaded patch set 9
V +106/07/24, 16:51 -
core-ci voted on patch set 9 V +1 06/07/24, 16:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58883
-
Stefan Bürk uploaded patch set 10
V +106/07/24, 17:47 -
core-ci voted on patch set 10 V +1 06/07/24, 17:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58884
-
Stefan Bürk uploaded patch set 11
V +106/10/24, 11:01 -
core-ci voted on patch set 11 V +1 06/10/24, 11:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58994
-
Christian Kuhn commented on patch set 11 06/10/24, 16:29
recursiveCommonTableExpression_pageTreeOne.csv:8uid 6 parent 1 with sorting 2 -> same as uid 2. maybe change this to not have a dupe-sorting here? -
Stefan Bürk uploaded patch set 12
V +106/10/24, 18:36 -
core-ci voted on patch set 12 V +1 06/10/24, 18:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59071
-
Stefan Bürk rebased onto patch set 13
V +106/11/24, 07:10 -
core-ci voted on patch set 13 V +1 06/11/24, 07:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59111
-
Stefan Bürk commented on patch set 13 06/11/24, 11:55
recursiveCommonTableExpression_pageTreeOne.csv:4ReplyDonerecursiveCommonTableExpression_pageTreeOne.csv:8ReplyDone -
Stefan Bürk rebased onto patch set 14
V +106/13/24, 11:48 -
core-ci voted on patch set 14 V +1 06/13/24, 11:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59473
-
Stefan Bürk rebased onto patch set 15
V +107/03/24, 09:48
-
core-ci voted on patch set 15 V +1 07/03/24, 09:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60899
-
Stefan Bürk uploaded patch set 16
V +107/25/24, 10:27 -
core-ci voted on patch set 16 V +1 07/25/24, 10:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62168
-
Stefan Bürk rebased onto patch set 17
V +107/25/24, 17:43 -
core-ci voted on patch set 17 V +1 07/25/24, 18:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62205
-
Stefan Bürk updated the commit message in patch set 18
V +107/25/24, 18:59 -
core-ci voted on patch set 18 V +1 07/25/24, 19:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62219
-
Stefan Bürk wrote 07/25/24, 19:15
Topic set to doctrine-dbal -
Stefan Bürk rebased onto patch set 19
V +107/26/24, 08:08 -
core-ci voted on patch set 19 V +1 07/26/24, 08:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62258
-
Stefan Bürk rebased onto patch set 20
V +107/27/24, 16:45 -
core-ci voted on patch set 20 V -1 07/27/24, 16:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62310
-
core-ci voted on patch set 20 V +1 07/27/24, 17:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62310
-
Stefan Bürk rebased onto patch set 21
V +107/27/24, 23:53 -
core-ci voted on patch set 21 V -1 07/28/24, 00:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62323
-
Stefan Bürk rebased onto patch set 22
V -107/28/24, 01:40 -
core-ci voted on patch set 22 V +1 07/28/24, 01:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62329
-
Stefan Bürk rebased onto patch set 23
V +107/29/24, 21:48 -
core-ci voted on patch set 23 V +1 07/29/24, 21:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62400
-
Stefan Bürk rebased onto patch set 24 07/30/24, 07:15
Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**") -
core-ci voted on patch set 24 V +1 07/30/24, 07:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62417
-
Christian Kuhn commented on patch set 24 CR +1 V +1 07/30/24, 11:53
i reviewed this one some weeks and i think it's fine. we now have further patches consuming this api already. i think we can go ahead and merge this now. -
Benni Mack voted on patch set 24 CR +1 V +1 07/30/24, 11:56
-
Stefan Bürk voted on patch set 24 CR +2 V +2 07/30/24, 12:00
-
Stefan Bürk merged patch set 25 07/30/24, 12:00
recursiveCommonTableExpression_pageTreeOne.csv:4