Review main Merged

84480[TASK] Add internal `Common Table Expression` support

Stefan Bürk CR +2 V +2 Expert +1523 −0 updated 07/30/24, 12:00

Commit message

`Common Table Expression` and special the recursive
variant can be extremely use-full for recursive tree
data, either in a rootline or tree traversal point of
view.

Adding internal `Common Table Expression` support to
the QueryBuilder class hierarchy, using a prefix for
the methods to avoid method signature issues in case
support can be officially added to `Doctrine DBAL`.

Instead of introducing a completly dedicated builder
architecture the QueryBuilder chain is extended to
provide it in a way it may be added to dbal directly,
except that methods are prefixed and made internal
for now to mitigate eventually signature issues.

This API is experimental and implementation based on
CTE **needs** extensive tests to ensure cross database
compatibility.

Basic tests are added to cover the API and showcase
CTE with simple implementations.

NOTE: This API will be contributed to doctrine/dbal,
and if accepted replaced with the doctrine version.
Otherwise, this API may be made public (as feature)
in the future.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 3156

Show 1731 earlier messages
  1. Stefan Bürk uploaded patch set 1 06/03/24, 16:54

  2. core-ci voted on patch set 1 V -1 06/03/24, 17:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58623

  3. Stefan Bürk uploaded patch set 2 V -1 06/06/24, 13:25

  4. Stefan Bürk uploaded patch set 3 06/06/24, 13:27

  5. core-ci voted on patch set 2 V -1 06/06/24, 13:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58798

  6. core-ci voted on patch set 3 V -1 06/06/24, 13:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58800

  7. Stefan Bürk uploaded patch set 4 V -1 06/07/24, 10:11

  8. core-ci voted on patch set 4 V -1 06/07/24, 10:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58868

  9. Stefan Bürk uploaded patch set 5 V -1 06/07/24, 10:25

  10. core-ci voted on patch set 5 V +1 06/07/24, 10:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58869

  11. Stefan Bürk uploaded patch set 6 V +1 06/07/24, 12:02

  12. core-ci voted on patch set 6 V +1 06/07/24, 12:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58875

  13. Stefan Bürk uploaded patch set 7 V +1 06/07/24, 12:43

  14. core-ci voted on patch set 7 V +1 06/07/24, 12:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58877

  15. Stefan Bürk uploaded patch set 8 V +1 06/07/24, 15:49

  16. core-ci voted on patch set 8 V +1 06/07/24, 15:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58882

  17. Stefan Bürk uploaded patch set 9 V +1 06/07/24, 16:51

  18. core-ci voted on patch set 9 V +1 06/07/24, 16:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58883

  19. Stefan Bürk uploaded patch set 10 V +1 06/07/24, 17:47

  20. core-ci voted on patch set 10 V +1 06/07/24, 17:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58884

  21. Stefan Bürk uploaded patch set 11 V +1 06/10/24, 11:01

  22. core-ci voted on patch set 11 V +1 06/10/24, 11:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58994

  23. Christian Kuhn commented on patch set 11 06/10/24, 16:29

    recursiveCommonTableExpression_pageTreeOne.csv:4

    uid 2 parent 1 with sorting 2

    recursiveCommonTableExpression_pageTreeOne.csv:8

    uid 6 parent 1 with sorting 2 -> same as uid 2. maybe change this to not have a dupe-sorting here?
  24. Stefan Bürk uploaded patch set 12 V +1 06/10/24, 18:36

  25. core-ci voted on patch set 12 V +1 06/10/24, 18:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59071

  26. Stefan Bürk rebased onto patch set 13 V +1 06/11/24, 07:10

  27. core-ci voted on patch set 13 V +1 06/11/24, 07:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59111

  28. Stefan Bürk commented on patch set 13 06/11/24, 11:55

    recursiveCommonTableExpression_pageTreeOne.csv:4 Reply

    Done

    recursiveCommonTableExpression_pageTreeOne.csv:8 Reply

    Done
  29. Stefan Bürk rebased onto patch set 14 V +1 06/13/24, 11:48

  30. core-ci voted on patch set 14 V +1 06/13/24, 11:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59473

  31. Stefan Bürk rebased onto patch set 15 V +1 07/03/24, 09:48

  1. core-ci voted on patch set 15 V +1 07/03/24, 09:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60899

  2. Stefan Bürk uploaded patch set 16 V +1 07/25/24, 10:27

  3. core-ci voted on patch set 16 V +1 07/25/24, 10:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62168

  4. Stefan Bürk rebased onto patch set 17 V +1 07/25/24, 17:43

  5. core-ci voted on patch set 17 V +1 07/25/24, 18:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62205

  6. Stefan Bürk updated the commit message in patch set 18 V +1 07/25/24, 18:59

  7. core-ci voted on patch set 18 V +1 07/25/24, 19:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62219

  8. Stefan Bürk wrote 07/25/24, 19:15

    Topic set to doctrine-dbal
  9. Stefan Bürk rebased onto patch set 19 V +1 07/26/24, 08:08

  10. core-ci voted on patch set 19 V +1 07/26/24, 08:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62258

  11. Stefan Bürk rebased onto patch set 20 V +1 07/27/24, 16:45

  12. core-ci voted on patch set 20 V -1 07/27/24, 16:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62310

  13. core-ci voted on patch set 20 V +1 07/27/24, 17:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62310

  14. Stefan Bürk rebased onto patch set 21 V +1 07/27/24, 23:53

  15. core-ci voted on patch set 21 V -1 07/28/24, 00:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62323

  16. Stefan Bürk rebased onto patch set 22 V -1 07/28/24, 01:40

  17. core-ci voted on patch set 22 V +1 07/28/24, 01:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62329

  18. Stefan Bürk rebased onto patch set 23 V +1 07/29/24, 21:48

  19. core-ci voted on patch set 23 V +1 07/29/24, 21:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62400

  20. Stefan Bürk rebased onto patch set 24 07/30/24, 07:15

    Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**")
  21. core-ci voted on patch set 24 V +1 07/30/24, 07:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62417

  22. Christian Kuhn commented on patch set 24 CR +1 V +1 07/30/24, 11:53

    i reviewed this one some weeks and i think it's fine. we now have further patches consuming this api already. i think we can go ahead and merge this now.
  23. Benni Mack voted on patch set 24 CR +1 V +1 07/30/24, 11:56

  24. Stefan Bürk voted on patch set 24 CR +2 V +2 07/30/24, 12:00

  25. Stefan Bürk merged patch set 25 07/30/24, 12:00