Review 12.4 Merged

84483[BUGFIX] Avoid text selection when dragging toolbar nodes

Andreas Kienast CR +2 V +2 Easy +2 −1 updated 06/06/24, 07:47

Commit message

With Chrome 125, changes in the drag&drop handling were introduced [1]
that trigger a text selection when dragging nodes from the page tree
toolbar.

In the `dragstart` handler, the default action is now prevented.

[1] https://developer.chrome.com/release-notes/125#interoperable_mousemove_default_action

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 811

  1. Andreas Kienast uploaded patch set 1 06/04/24, 06:01

  2. core-ci voted on patch set 1 V +1 06/04/24, 06:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58662

  3. Andreas Kienast updated the commit message in patch set 2 V +1 06/04/24, 06:55

  4. Benjamin Franzke voted on patch set 2 CR +1 06/04/24, 06:55

  5. core-ci voted on patch set 2 V -1 06/04/24, 07:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58663

  6. core-ci voted on patch set 2 V +1 06/04/24, 07:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58663

  7. Benjamin Franzke voted on patch set 2 V +1 06/04/24, 07:06

  8. Christian Kuhn voted on patch set 2 CR +1 V +1 06/05/24, 14:13

  9. Benni Mack voted on patch set 2 CR +1 V +1 06/06/24, 05:24

  10. Benjamin Franzke voted on patch set 2 CR +2 V +2 06/06/24, 07:31

  11. Benjamin Franzke merged patch set 3 06/06/24, 07:47