84485[TASK] Reduce GU::makeInstance calls in Unit Tests
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
-
Verified V +2 Done
- Benjamin Franzke +2
- core-ci +1 CI
Issues 1
Files 26
- Build/phpstan/phpstan-baseline.neon+0 −5
- typo3/sysext/core/Tests/Unit/Authentication/Mfa/Provider/RecoveryCodesTest.php+1 −2
- typo3/sysext/core/Tests/Unit/Authentication/Mfa/Provider/TotpTest.php+12 −10
- typo3/sysext/core/Tests/Unit/Authentication/IpLockerTest.php+2 −3
- typo3/sysext/core/Tests/Unit/Configuration/CKEditor5MigratorTest.php+1 −6
- typo3/sysext/core/Tests/Unit/Configuration/SiteConfigurationTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/AbstractRestrictionTestCase.php+1 −2
- typo3/sysext/core/Tests/Unit/Imaging/IconProvider/BitmapIconProviderTest.php+1 −2
- typo3/sysext/core/Tests/Unit/Imaging/IconProvider/SvgIconProviderTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Imaging/IconProvider/SvgSpriteIconProviderTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Log/Processor/AbstractProcessorTest.php+1 −2
- typo3/sysext/core/Tests/Unit/Log/Writer/FileWriterTest.php+6 −20
- typo3/sysext/core/Tests/Unit/Messaging/Renderer/BootstrapRendererTest.php+6 −8
- typo3/sysext/core/Tests/Unit/Messaging/Renderer/ListRendererTest.php+6 −9
- typo3/sysext/core/Tests/Unit/Messaging/Renderer/PlaintextRendererTest.php+6 −9
- typo3/sysext/core/Tests/Unit/Messaging/FlashMessageRendererResolverTest.php+1 −3
- typo3/sysext/core/Tests/Unit/MetaTag/GenericMetaTagManagerTest.php+3 −1
- typo3/sysext/core/Tests/Unit/Page/AssetCollectorTest.php+1 −2
- typo3/sysext/core/Tests/Unit/Page/AssetRendererTest.php+20 −22
- typo3/sysext/core/Tests/Unit/Type/File/ImageInfoTest.php+4 −4
Show 6 more files
- typo3/sysext/dashboard/Tests/Unit/DashboardPresetRegistryTest.php+1 −4
- typo3/sysext/dashboard/Tests/Unit/WidgetGroupRegistryTest.php+1 −23
- typo3/sysext/frontend/Tests/Unit/ContentObject/Menu/AbstractMenuContentObjectTest.php+2 −1
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+1 −1
- typo3/sysext/t3editor/Tests/Unit/Registry/AddonRegistryTest.php+4 −5
- typo3/sysext/t3editor/Tests/Unit/Registry/ModeRegistryTest.php+4 −5
Review log 24
-
Benjamin Franzke uploaded patch set 1 06/04/24, 07:46
-
core-ci voted on patch set 1 V -1 06/04/24, 07:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58665
-
core-ci voted on patch set 1 V +1 06/04/24, 07:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58665
-
Benjamin Franzke merged patch set 2 06/04/24, 08:26