Review 12.4 Merged

84485[TASK] Reduce GU::makeInstance calls in Unit Tests

Benjamin Franzke CR +2 V +2 Normal +90 −154 updated 06/04/24, 08:26

Commit message

Additional potential functionality (DI, XClass resolving, etc.) of
GU::makeInstance is usually not a wanted behaviour in unit tests.
For creation of system under test `new` should be used.
Dependencies, if necessary, should be mocks.
This patch reduces the obvious cases, more complicated ones will
be tackled with follow ups.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 26

Show 6 more files

Review log 24

  1. Benjamin Franzke uploaded patch set 1 06/04/24, 07:46

  2. core-ci voted on patch set 1 V -1 06/04/24, 07:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58665

  3. core-ci voted on patch set 1 V +1 06/04/24, 07:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58665

  4. Benjamin Franzke merged patch set 2 06/04/24, 08:26