Review main Merged

84487[BUGFIX] IRRE: Rewrite stylesheet loading sequence

Andreas Kienast CR +2 V +2 Easy +10 −13 updated 06/04/24, 11:33

Commit message

The stylesheet loading process in IRRE was kept for several years and
moved from version to version. A recent change in #103375 migrated a
usage of `delete` to `.splice()`, breaking stylesheet loading as the
original iterated object was modified.

Since the code was quite dated and had other potental bugs, the whole
loading sequence has been transformed to functional programming style
to reduce complicated, potentially error-prone, array operations.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • rogier Helmer +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • rogier Helmer +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 56

  1. Andreas Kienast uploaded patch set 1 06/04/24, 09:44

  2. Benjamin Franzke voted on patch set 1 CR +1 V +1 06/04/24, 09:48

  3. core-ci voted on patch set 1 V +1 06/04/24, 09:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58670

  4. rogier Helmer commented on patch set 1 CR +1 V +1 06/04/24, 11:13

    Tested. Works in out project.
  5. Benjamin Franzke voted on patch set 1 CR +2 V +2 06/04/24, 11:26

  6. Benjamin Franzke merged patch set 2 06/04/24, 11:33