Review 12.4 Merged

84488[BUGFIX] IRRE: Rewrite stylesheet loading sequence

Benjamin Franzke CR +2 V +2 Easy +10 −13 updated 06/04/24, 11:33

Commit message

The stylesheet loading process in IRRE was kept for several years and
moved from version to version. A recent change in #103375 migrated a
usage of `delete` to `.splice()`, breaking stylesheet loading as the
original iterated object was modified.

Since the code was quite dated and had other potental bugs, the whole
loading sequence has been transformed to functional programming style
to reduce complicated, potentially error-prone, array operations.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 23

  1. Benjamin Franzke uploaded patch set 1 06/04/24, 11:25

  2. core-ci voted on patch set 1 V +1 06/04/24, 11:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58678

  3. Benjamin Franzke merged patch set 2 06/04/24, 11:33