Review main Merged

84489[BUGFIX] Properly show multiple cropping coverAreas per cropVariant

Leon Dietsch CR +2 V +2 Normal +71 −3 updated 06/21/24, 09:40

Commit message

When switching between cropVariants with multiple coverAreas,
all of the previous coverAreas are properly removed, only
showing those that belong to a specific cropVariant.

See details and screenshots in the related ticket.

(A new styleguide TCA element crop_9 is also added
to showcase multiple coverAreas in multiple cropVariants)

Review

  • Code review CR +2 Done
    • Andreas Nedbal +2
    • Chris Müller +1
    • Georg Ringer +1
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Nedbal +2
    • Chris Müller +1
    • Georg Ringer +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1519

  1. Leon Dietsch uploaded patch set 1 06/04/24, 14:34

  2. core-ci voted on patch set 1 V +1 06/04/24, 14:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58682

  3. Garvin Hicking uploaded patch set 2 V +1 06/04/24, 15:56

    Add corresponding styleguide TCA example
  4. Garvin Hicking commented on patch set 2 CR +1 V +1 06/04/24, 15:59

    This solves the issue for me, nice! 😊 I took the liberty to add a EXT:styleguide representation to make this bug easier reviewable, by adding a styleguide element of type "Form engine elements - imageManipulation" with the new element "crop_9", using Chris' originally reported configuration. (For a v12 backport this will probably have to be removed, as EXT:styleguide isn't bundled with v12 core, so I hope I didn't make this overly complicated. Remove it again, if unwanted)
  5. core-ci voted on patch set 2 V +1 06/04/24, 16:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58686

  6. Chris Müller voted on patch set 2 CR +1 V +1 06/05/24, 07:32

  7. Garvin Hicking updated the commit message in patch set 3 CR +1 V +1 06/05/24, 08:05

  8. Garvin Hicking voted on patch set 3 CR +1 V +1 06/05/24, 08:05

  9. core-ci voted on patch set 3 V +1 06/05/24, 08:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58730

  10. Chris Müller voted on patch set 3 CR +1 V +1 06/05/24, 08:14

  11. Garvin Hicking uploaded patch set 4 CR +1 V +1 06/13/24, 10:32

    rebase
  12. Garvin Hicking commented on patch set 4 CR +1 V +1 06/13/24, 10:34

    (rebased)
  13. core-ci voted on patch set 4 V +1 06/13/24, 10:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59458

  14. Andreas Nedbal voted on patch set 4 CR +1 V +1 06/13/24, 12:02

  15. Chris Müller voted on patch set 4 CR +1 V +1 06/14/24, 09:06

  16. Georg Ringer voted on patch set 4 CR +1 V +1 06/14/24, 11:08

  17. Benni Mack voted on patch set 4 CR +1 06/21/24, 09:39

  18. Andreas Nedbal voted on patch set 4 CR +2 V +2 06/21/24, 09:40

  19. Andreas Nedbal merged patch set 5 06/21/24, 09:40