Review main Merged

84490[TASK] Add styleguide example for inline+collapseAll+date combo

Garvin Hicking CR +2 V +2 Normal +137 −1 updated 06/13/24, 06:39

Commit message

The issue reported in #93743 seems to
not be reproducible in main, the datepicker
works even when "collapseAll=true" (and
"collapseAll=true") is set in the TCA.

To easily reproduce the scenario,
a new styleguide TCA element
"Form engine - inline expand single - inline_2"
is introduced and added as inline relation
to "Form engine - inline expand single".

The inline elements are dateTime inputs.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1216

  1. Garvin Hicking uploaded patch set 1 06/04/24, 15:25

  2. core-ci voted on patch set 1 V +1 06/04/24, 15:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58683

  3. Christian Kuhn commented on patch set 1 06/10/24, 17:23

    tx_styleguide_inline_expand.php:97

    issue says 'collapseAll' => true and 'expandSingle' => true.
  4. Garvin Hicking uploaded patch set 2 V +1 06/10/24, 17:46

  5. Garvin Hicking commented on patch set 1 06/10/24, 17:46

    tx_styleguide_inline_expand.php:97 Reply

    D'oh. Fixed. I tested and reverted this one too many time and committed the wrong version -.- Thanks for your attentive set of beautiful hazel eyes, Monsieur.
  6. core-ci voted on patch set 2 V +1 06/10/24, 17:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59064

  7. Georg Ringer voted on patch set 2 CR +1 V +1 06/10/24, 20:19

  8. Christian Kuhn commented on patch set 2 06/11/24, 17:42

    maybe move it to expandsingle?
  9. Garvin Hicking uploaded patch set 3 CR +1 V +1 06/12/24, 16:00

    Rename all the things
  10. Garvin Hicking uploaded patch set 4 06/12/24, 16:00

    Spaaaace
  11. Garvin Hicking commented on patch set 4 06/12/24, 16:02

    Reply

    I'm Happy Dave, I'm Positive I Can Do That
  12. core-ci voted on patch set 4 V +1 06/12/24, 16:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59348

  13. core-ci voted on patch set 3 V +1 06/12/24, 16:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59347

  14. Christian Kuhn voted on patch set 4 CR +1 V +1 06/12/24, 19:13

  15. Georg Ringer voted on patch set 4 CR +2 V +2 06/13/24, 06:39

  16. Georg Ringer merged patch set 5 06/13/24, 06:39