Review main Merged

84491[BUGFIX] Do not set original token value stream in TS AstBuilder

Christian Kuhn CR +2 V +2 Easy +3 −3 updated 06/04/24, 16:21

Commit message

The 'original value token stream' is a helper used in
BE TypoScript modules to render a possible constant
substitution.
It is enough if the CommentAwareAstBuilder handles this,
which is used in those cases: getOriginalValueTokenStream()
is only called by fluid as 'child.originalValueTokenStream'
when rendering TS trees in the backend. Those use
CommentAwareAstBuilder and not "production" AstBuilder.
The patch avoids calling setOriginalValueTokenStream() as
a minor micro optimization which may also help the garbage
collection to clean up some objects more early in FE.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 3