Review 12.4 Merged

84500[BUGFIX] Restore open document selector class

Ulrich Mathes CR +2 V +2 Easy +1 −1 updated 06/05/24, 14:02

Commit message

Adds required CSS class `t3js-topbar-opendocs-item` to each open
document item. OpendocsMenu JavaScript module counts these items to
show count of open documents in badge.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Ulrich Mathes uploaded patch set 1 06/05/24, 11:03

  2. core-ci voted on patch set 1 V +1 06/05/24, 11:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58738

  3. Ulrich Mathes wrote 06/05/24, 11:18

    Topic set to Backend UI
  4. Christian Kuhn commented on patch set 1 V -1 06/05/24, 13:51

    ok, the badge is back, but it now always shows "1" to me, no matter how many open records there are? can you confirm? note: confirm this is broken in v12 only, no patch needed for v11 & main.
  5. Ulrich Mathes uploaded patch set 2 V +1 06/05/24, 13:54

  6. Christian Kuhn voted on patch set 2 CR +1 V +1 06/05/24, 13:57

  7. Christian Kuhn commented on patch set 2 06/05/24, 13:58

    lgtm. thx!
  8. core-ci voted on patch set 2 V +1 06/05/24, 14:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58750

  9. Stefan Bürk commented on patch set 2 CR +2 V +2 06/05/24, 14:02

    thx for the fix
  10. Stefan Bürk merged patch set 3 06/05/24, 14:02