Review main Merged

84506[TASK] Require array in setFlatConstants()

Christian Kuhn CR +2 V +2 Easy +4 −4 updated 06/05/24, 15:33

Commit message

Constant substitution in TS parser is implemented in
ConstantAwareTokenStream. It kicks in by casting the
stream to string after existing constants have been
set using ConstantAwareTokenStream->setFlatConstants().

To not have a "polluted" stream after setFlatConstants(),
the constants are reset using setFlatConstants(null)
after use. Ugly. Patch #102742 established a partial
solution already by cloning the stream instead.

Finish the clone approach to disallow setFlatConstants(null).
Add two missing void return annotations at related places
along the way.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 3

Files 4