84508[FEATURE] User TsConfig option for default resources ViewMode
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Julian Hofmann +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Julian Hofmann +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 6
- typo3/sysext/backend/Classes/Middleware/BackendModuleValidator.php+1 −1
- typo3/sysext/core/Documentation/Changelog/13.2/Feature-102155-UserTSconfigOptionForDefaultViewModeInFileList.rstnew+33 −0
- typo3/sysext/filelist/Classes/Controller/FileListController.php+5 −0
- typo3/sysext/filelist/Classes/ElementBrowser/AbstractResourceBrowser.php+9 −7
- typo3/sysext/filelist/Classes/LinkHandler/AbstractResourceLinkHandler.php+9 −7
- typo3/sysext/filelist/Configuration/Backend/Modules.php+1 −2
Review log 2234
Show 59 earlier messages
-
Julian Hofmann uploaded patch set 1 06/05/24, 21:00
-
core-ci voted on patch set 1 V -1 06/05/24, 21:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58766
-
Julian Hofmann uploaded patch set 2 06/05/24, 21:10
Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**") -
Julian Hofmann uploaded patch set 3
V -106/05/24, 21:12 -
core-ci voted on patch set 2 V -1 06/05/24, 21:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58767
-
core-ci voted on patch set 3 V +1 06/05/24, 21:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58768
-
Benni Mack commented on patch set 3 06/06/24, 05:24
Hey Julian, thanks for the change, we now only need a Feature.RST for this. https://forger.typo3.com/utilities/rst https://docs.typo3.org/m/typo3/guide-contributionworkflow/main/en-us/AddingDocumentation/Index.html -
Julian Hofmann uploaded patch set 4
V +106/06/24, 06:26 -
core-ci voted on patch set 4 V +1 06/06/24, 06:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58787
-
Julian Hofmann uploaded patch set 5
V +106/06/24, 06:41 -
core-ci voted on patch set 5 V +1 06/06/24, 06:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58788
-
Julian Hofmann commented on patch set 5 06/06/24, 09:54
Reply
Done -
Georg Ringer commented on patch set 6
V +106/06/24, 10:52Published edit on patch set 5. -
Georg Ringer voted on patch set 6 CR +1 V +1 06/06/24, 10:53
-
core-ci voted on patch set 6 V +1 06/06/24, 10:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58793
-
Oli Bartsch uploaded patch set 7
CR +1V +106/06/24, 11:40 -
Oli Bartsch commented on patch set 7 06/06/24, 11:43
Thanks for your patch! I've adjusted the patch a bit. Especially, I removed the key from the module configuration since this won't be set via GET/POST in the filelist module and additionally, the empty string would be an invalid value. The patch itself works as expected. However, I'm thinking of adding a more general TSconfig to also define the default viewMode for the file browser. What do you think? -
core-ci voted on patch set 7 V -1 06/06/24, 11:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58795
-
Julian Hofmann commented on patch set 7 06/06/24, 12:04
Reply
A more general TSconfig would be a good idea. IMO, we do not have something like a `mod.file_list` so far. That is why I have added the new option beside all the existing `options.file_list.*` (https://docs.typo3.org/m/typo3/reference-tsconfig/main/en-us/UserTsconfig/Options.html#file-list). -
Julian Hofmann uploaded patch set 8
V -106/06/24, 13:16 -
core-ci voted on patch set 8 V -1 06/06/24, 13:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58797
-
Julian Hofmann uploaded patch set 9 06/06/24, 13:26
Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**") -
Julian Hofmann uploaded patch set 10 06/06/24, 13:32
Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**") -
core-ci voted on patch set 9 V -1 06/06/24, 13:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58799
-
core-ci voted on patch set 10 V -1 06/06/24, 13:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58801
-
Oli Bartsch uploaded patch set 11
V -106/06/24, 15:51 -
core-ci voted on patch set 11 V +1 06/06/24, 15:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58815
-
Oli Bartsch commented on patch set 11 06/06/24, 20:56
Reply
Done -
Benni Mack commented on patch set 12
V +106/06/24, 21:01Published edit on patch set 11. -
Benni Mack voted on patch set 12 CR +1 V +1 06/06/24, 21:01
-
core-ci voted on patch set 12 V +1 06/06/24, 21:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58825
-
Julian Hofmann voted on patch set 12 CR +1 V +1 06/07/24, 08:26
-
Oli Bartsch voted on patch set 12 CR +2 V +2 06/07/24, 08:31
-
Oli Bartsch merged patch set 13 06/07/24, 08:31