Review main Merged

84510[DOCS] Use GitHub permalink to CKEditor Base.yaml

TYPO3com CR +2 V +2 Easy +2 −3 updated 06/20/24, 13:42

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Lina Wolf +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Lina Wolf +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1620

  1. TYPO3com uploaded patch set 1 06/06/24, 09:07

  2. core-ci voted on patch set 1 V +1 06/06/24, 09:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58790

  3. Benjamin Franzke commented on patch set 1 06/06/24, 11:43

    Reference.rst:85

    I think we should reference the 12.4 branch instead of a single hash
  4. Garvin Hicking commented on patch set 1 06/06/24, 17:00

    Reference.rst:85 Reply

    I think linking to a github file of a specific version in the docs is generally a problem. When we have "main" as the link in this "main" and release v14, we would need to go back to "v13" and adjust the link to "v13". I must admit I don't have a great solution for this, but IMO letting also versions of v12, v13, main, v14, ... always point to "main" for the github link would be ok, so people can choose their right version from the GitHub UI then?! BTW, this patch seems to have a few dupes that didn't make it through to gerrit: https://github.com/TYPO3/typo3/pull/495 https://github.com/TYPO3/typo3/pull/496 https://github.com/TYPO3/typo3/pull/497 https://github.com/TYPO3/typo3/pull/498 https://forge.typo3.org/issues/103983 https://forge.typo3.org/issues/103984 https://forge.typo3.org/issues/103985 https://forge.typo3.org/issues/103986
  5. Chris Müller commented on patch set 1 06/06/24, 18:42

    Reference.rst:85 Reply

    We can use ":t3src:`rte_ckeditor/Configuration/RTE/Editor/Base.yaml` We use that, for example, here: https://docs.typo3.org/m/typo3/reference-coreapi/12.4/en-us/ApiOverview/Logging/Processors/Index.html#logging-processors-custom The version is adapted automatically depending on the "typo3-core-preferred" attribute in guides.xml AFAIK.
  6. Georg Ringer wrote 06/06/24, 23:54

    Change destination moved from 12.4 to main
  7. Georg Ringer updated the commit message in patch set 2 06/06/24, 23:55

  8. Georg Ringer commented on patch set 2 06/06/24, 23:56

    just getting the branches right, as there have been 3 PR to github and 4 issues created at forge :/
  9. core-ci voted on patch set 2 V +1 06/07/24, 00:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58827

  10. Garvin Hicking commented on patch set 2 06/07/24, 07:46

    Reference.rst:85 Reply

    @typo3@brotkrueml.dev Hm but your example is rendered pointing to "main" for all of 11.5, 12.4 and "main" - so it seems if this should work, it doesn't work - so the problem would remain...?
  11. Garvin Hicking commented on patch set 2 06/07/24, 07:51

    Reference.rst:85 Reply

    (Filed as https://github.com/TYPO3-Documentation/render-guides/issues/603 to inspect this behavior after talking to Lina)
  12. Lina Wolf commented on patch set 2 06/09/24, 08:55

    Reference.rst:85 Reply

    the typo3-version="main" is missing in the guides.xml
  13. Lina Wolf commented on patch set 2 06/09/24, 09:04

    Reference.rst:85 Reply

    I think it is actually a bug in the render-guides, typo3_core_preferred should be used
  14. Lina Wolf commented on patch set 2 06/09/24, 12:18

    Reference.rst:85 Reply

    With the newest render-guides release the behaviour of t3src was fixed, it now always goes to the version of typo3-core-preferred
  15. Garvin Hicking uploaded patch set 3 V +1 06/09/24, 18:57

    Use t3src
  16. Garvin Hicking commented on patch set 3 CR +1 V +1 06/09/24, 19:00

    Reference.rst:85 Reply

    Thank you lina, I can verify this works now. Adjusted the patch to make use of t3src and also at a second place. Rendered it in main and v12 and the links properly point to the relative version. (Used: `docker run --rm --pull always -v ./:/project/ ghcr.io/typo3-documentation/render-guides:latest --no-progress --config=typo3/sysext/rte_ckeditor/Documentation typo3/sysext/rte_ckeditor/Documentation`)
  17. core-ci voted on patch set 3 V +1 06/09/24, 19:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58957

  18. Lina Wolf commented on patch set 3 CR +1 V +1 06/20/24, 13:18

    Thanks for taking care of this
  19. Christian Kuhn voted on patch set 3 CR +2 V +2 06/20/24, 13:25

  20. Christian Kuhn merged patch set 4 06/20/24, 13:42