Review main Merged

84511[TASK] Make TS [END] an own include object

Christian Kuhn CR +2 V +2 Normal +197 −9 updated 06/07/24, 00:30

Commit message

The new v12 TypoScript parser works pretty well. It is time
to rule out some of its rough edges in v13: In hinsight,
the biggest structural issues of the rewrite reside in the
IncludeTree structure, which has been oversimplified at some
places.

One problem is reflected within the BE modules 'TypoScript ->
Included TypoScript' and 'Page TSconfig -> Include page TSconfig',
which are not as easy to grasp as they could be. Those are
essentially a straight view of the created IncludeTree.

The patch changes a single decision within these trees:
"condition end" token ("[END]" / "[GLOBAL]") have been added
to the line stream of the currently given tree object until
now, but they should be a dedicated node reflected in the tree.

The patch turns "condition stop" into dedicated objects within
the tree. This makes BE include tree display more easy to grasp
and allows simplified scanning for missing and superfluous condition
stop lines in the future. It is also a base for better rendering
of the "code view" within the modules.

Additionally, condition and condition-else now render their
condition tokens in the BE modules, which should help
integrators to understand the tree more easily by simplified
matching to known parts of TS source.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 3

Files 9