Review main Merged

84512[BUGFIX] Remove backtick operator in runTests.sh help output

Garvin Hicking CR +2 V +2 Easy +1 −1 updated 06/06/24, 15:45

Commit message

The use of the backtick operator inside the help output leads
to an error message:

  Build/Scripts/runTests.sh: line 175: --: command not found

on macOS (probably others, too).

This patch replaces the backticks with normal quotes.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Jochen Roth +1
    • Patrick Schriner +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Jochen Roth +1
    • Patrick Schriner +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Garvin Hicking uploaded patch set 1 06/06/24, 14:27

  2. core-ci voted on patch set 1 V +1 06/06/24, 14:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58802

  3. Stefan Bürk updated the commit message in patch set 2 V +1 06/06/24, 15:14

  4. Stefan Bürk voted on patch set 2 CR +1 V +1 06/06/24, 15:19

  5. core-ci voted on patch set 2 V +1 06/06/24, 15:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58805

  6. Patrick Schriner voted on patch set 2 CR +1 V +1 06/06/24, 15:41

  7. Jochen Roth voted on patch set 2 CR +1 V +1 06/06/24, 15:43

  8. Stefan Bürk voted on patch set 2 CR +2 V +2 06/06/24, 15:44

  9. Stefan Bürk merged patch set 3 06/06/24, 15:45