Review main Merged

84516[BUGFIX] Improve ARIA-attributes of Lit Element tree

Ayke Halder CR +2 V +2 Easy +12 −12 updated 12/18/24, 14:32

Commit message

This improves the ARIA-attributes of the Lit Element trees treeitems.

`aria-owns` and `aria-expanded` must not have an empty value. Only
render them if there are child-treenodes and therefore their value is
not empty.
Without this change these attributes were rendered with an empty value.

`aria-level` must be a positive integer, therefore `0` is not allowed.
See:
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-level#values

`div` tags must not be rendered inside `span` tags.
This changes `span` tags to `div` if they contain `div` tags.
All changed `span` tags already have set CSS `display: flex`.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1015

  1. Ayke Halder uploaded patch set 1 06/06/24, 17:26

  2. core-ci voted on patch set 1 V +1 06/06/24, 17:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58823

  3. Ayke Halder updated the commit message in patch set 2 V +1 06/07/24, 07:08

  4. Ayke Halder updated the commit message in patch set 3 06/07/24, 07:10

  5. core-ci voted on patch set 2 V +1 06/07/24, 07:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58848

  6. core-ci voted on patch set 3 V +1 06/07/24, 07:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58849

  7. Christian Rath-Ulrich voted on patch set 3 CR +1 V +1 07/17/24, 15:19

  8. Oli Bartsch uploaded patch set 4 CR +1 V +1 12/18/24, 12:24

  9. Oli Bartsch updated the commit message in patch set 5 12/18/24, 12:24

  10. Oli Bartsch voted on patch set 5 CR +1 V +1 12/18/24, 12:25

  11. core-ci voted on patch set 4 V +1 12/18/24, 12:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71375

  12. core-ci voted on patch set 5 V +1 12/18/24, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71376

  13. Benni Mack voted on patch set 5 CR +1 V +1 12/18/24, 13:49

  14. Oli Bartsch voted on patch set 5 CR +2 V +2 12/18/24, 14:31

  15. Oli Bartsch merged patch set 6 12/18/24, 14:32