Review main Merged

84517[BUGFIX] Add language key for "SiteTemplate" in TypoScript submodule

Jasmina Ließmann CR +2 V +2 Easy +3 −0 updated 06/08/24, 20:55

Commit message

The "Included TypoScript" submodule shows the type of tree child as
a badge.
This patch adds a missing corresponding language key for the newly
introdued site sets.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1113

  1. Jasmina Ließmann uploaded patch set 1 06/06/24, 18:26

  2. core-ci voted on patch set 1 V +1 06/06/24, 18:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58824

  3. Jasmina Ließmann commented on patch set 1 CR +1 06/06/24, 18:32

    I'm not sure whether the wording "TypoScript set (included via file)" and "Part of a TypoScript set" is still appropriate in case of site sets. I'm investigating this further. Therefore temporarily -1.
  4. Jasmina Ließmann voted on patch set 1 CR -1 06/06/24, 18:33

  5. Christian Kuhn commented on patch set 1 06/07/24, 08:06

    Reply

    yeah. they're not great in this context. i'm fiddling with file includes with https://review.typo3.org/c/Packages/TYPO3.CMS/+/84515 and suggest to change those with that patch, and bring in this one as is.
  6. Christian Kuhn commented on patch set 1 06/07/24, 08:07

    maybe relate to the patch that added site sets?
  7. Jasmina Ließmann uploaded patch set 2 CR -1 V +1 06/07/24, 10:05

  8. Jasmina Ließmann commented on patch set 2 06/07/24, 10:06

    Reply

    Acknowledged

    Reply

    Done
  9. core-ci voted on patch set 2 V +1 06/07/24, 10:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58867

  10. Christian Kuhn voted on patch set 2 CR +1 V +1 06/08/24, 20:47

  11. Garvin Hicking voted on patch set 2 CR +1 V +1 06/08/24, 20:52

  12. Stefan Bürk voted on patch set 2 CR +2 V +2 06/08/24, 20:55

  13. Stefan Bürk merged patch set 3 06/08/24, 20:55