84519[DOCS] Fix typos in EXT:dashboard widget documentation
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
-
Verified V +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1520
-
TYPO3com uploaded patch set 1 06/07/24, 07:16
-
core-ci voted on patch set 1 V +1 06/07/24, 07:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58850
-
Garvin Hicking commented on patch set 1 CR +1 V +1 06/07/24, 07:21
Indeed, thanks for the contribution! :) -
Garvin Hicking updated the commit message in patch set 2
CR +1V +106/07/24, 07:21 -
Garvin Hicking updated the commit message in patch set 3 06/07/24, 07:22
-
Garvin Hicking voted on patch set 3 CR +1 V +1 06/07/24, 07:22
-
core-ci voted on patch set 2 V +1 06/07/24, 07:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58851
-
core-ci voted on patch set 3 V +1 06/07/24, 07:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58852
-
Riccardo De Contardi commented on patch set 3 06/07/24, 07:33
WidgetSettings.rst:14what about removing this "a" and write "Each widget should provide documentation..." ? -
Lina Wolf commented on patch set 3 CR +2 V +2 06/07/24, 07:33
No-brainer -
Lina Wolf voted on patch set 3 CR 0 V 0 06/07/24, 07:33
-
Oli Bartsch commented on patch set 3 CR +2 V +2 06/07/24, 07:42
WidgetSettings.rst:14ReplyI'm in favor of just fixing the typo for now. I hope this is fine for you. -
Garvin Hicking uploaded patch set 4
CR +1V +106/07/24, 07:42code review -
Christian Kuhn commented on patch set 3 06/07/24, 07:43
remove linebreak? -
Christian Kuhn commented on patch set 4 06/07/24, 07:43
Reply
Done -
Garvin Hicking commented on patch set 4 CR +1 V +1 06/07/24, 07:43
WidgetSettings.rst:14ReplySorry I just addressed this, asked Lina Wolf on Slack. Also changed the uppercase notation. OK? -
Riccardo De Contardi commented on patch set 4 06/07/24, 07:46
WidgetSettings.rst:14ReplyFine for me -
Oli Bartsch commented on patch set 4 CR +2 V +2 06/07/24, 07:46
WidgetSettings.rst:14ReplyAcknowledged -
core-ci voted on patch set 4 V +1 06/07/24, 07:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58856
-
Oli Bartsch merged patch set 5 06/07/24, 08:28