Review main Merged

84519[DOCS] Fix typos in EXT:dashboard widget documentation

TYPO3com CR +2 V +2 Easy +6 −6 updated 06/07/24, 08:28

Commit message

A few minor spelling mistakes and uppercase notation
is changed with this patch.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1520

  1. TYPO3com uploaded patch set 1 06/07/24, 07:16

  2. core-ci voted on patch set 1 V +1 06/07/24, 07:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58850

  3. Garvin Hicking commented on patch set 1 CR +1 V +1 06/07/24, 07:21

    Indeed, thanks for the contribution! :)
  4. Garvin Hicking updated the commit message in patch set 2 CR +1 V +1 06/07/24, 07:21

  5. Garvin Hicking updated the commit message in patch set 3 06/07/24, 07:22

  6. Garvin Hicking voted on patch set 3 CR +1 V +1 06/07/24, 07:22

  7. core-ci voted on patch set 2 V +1 06/07/24, 07:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58851

  8. core-ci voted on patch set 3 V +1 06/07/24, 07:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58852

  9. Riccardo De Contardi commented on patch set 3 06/07/24, 07:33

    WidgetSettings.rst:14

    what about removing this "a" and write "Each widget should provide documentation..." ?
  10. Lina Wolf commented on patch set 3 CR +2 V +2 06/07/24, 07:33

    No-brainer
  11. Lina Wolf voted on patch set 3 CR 0 V 0 06/07/24, 07:33

  12. Oli Bartsch commented on patch set 3 CR +2 V +2 06/07/24, 07:42

    WidgetSettings.rst:14 Reply

    I'm in favor of just fixing the typo for now. I hope this is fine for you.
  13. Garvin Hicking uploaded patch set 4 CR +1 V +1 06/07/24, 07:42

    code review
  14. Christian Kuhn commented on patch set 3 06/07/24, 07:43

    remove linebreak?
  15. Christian Kuhn commented on patch set 4 06/07/24, 07:43

    Reply

    Done
  16. Garvin Hicking commented on patch set 4 CR +1 V +1 06/07/24, 07:43

    WidgetSettings.rst:14 Reply

    Sorry I just addressed this, asked Lina Wolf on Slack. Also changed the uppercase notation. OK?
  17. Riccardo De Contardi commented on patch set 4 06/07/24, 07:46

    WidgetSettings.rst:14 Reply

    Fine for me
  18. Oli Bartsch commented on patch set 4 CR +2 V +2 06/07/24, 07:46

    WidgetSettings.rst:14 Reply

    Acknowledged
  19. core-ci voted on patch set 4 V +1 06/07/24, 07:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58856

  20. Oli Bartsch merged patch set 5 06/07/24, 08:28