84521[TASK] Showcase colorPalette in EXT:styleguide
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Georg Ringer +1
-
Verified V +2 Done
- Christian Kuhn +2
- Georg Ringer +1
- core-ci +1 CI
Issues 3
Files 2
Review log 2230
Show 35 earlier messages
-
Garvin Hicking uploaded patch set 1 06/07/24, 08:19
-
core-ci voted on patch set 1 V +1 06/07/24, 08:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58859
-
Garvin Hicking uploaded patch set 2
V +106/07/24, 08:53Use distinct palette -
core-ci voted on patch set 2 V +1 06/07/24, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58863
-
Garvin Hicking updated the commit message in patch set 3
V +106/07/24, 09:01
-
core-ci voted on patch set 3 V +1 06/07/24, 09:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58864
-
Georg Ringer voted on patch set 3 CR +1 V +1 06/07/24, 11:06
-
Christian Kuhn updated the commit message in patch set 4
CR +1V +106/10/24, 17:28 -
core-ci voted on patch set 4 V +1 06/10/24, 17:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59060
-
Christian Kuhn commented on patch set 4 CR -1 06/10/24, 17:37
i don't get it. recreating example tca tree does not reveal anything. -
Garvin Hicking commented on patch set 4 06/10/24, 17:48
Reply
This could be some problem with Site Set resolving or so, not related with this patch per se. I only got it to work when I edited the "TCA Tree" and included "Styleguide" as a TSconfig resource. -
Garvin Hicking uploaded patch set 5
CR -1V +106/13/24, 07:24Enable site set for TCA backend tree -
Garvin Hicking commented on patch set 4 06/13/24, 07:26
I've now made the TCA backend tree generator utilize the Site Set in the backend and think that would be helpful there, would love to get feedback for this. I can also create a distinct Site Set for it, or specify a "legacy" page.tsconfig file - but I'd really like to avoid duplication here when the current Site Set would neatly apply to the TCA tree in the backend too. -
Garvin Hicking commented on patch set 5 06/13/24, 07:26
Reply
Done -
core-ci voted on patch set 5 V -1 06/13/24, 07:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59410
-
Garvin Hicking commented on patch set 5 06/13/24, 10:20
Meh. Acceptance tests fail because the TCA tree was used to verify that "no typoscript records" exist. Solutions: 1. Create a second backend tree (which is used for that test) without TS 2. Utilize TS only for a sub-part of the TCA tree (so that the colorpicker works), not using the site set Kinda undecided. Oppinions? -
Garvin Hicking uploaded patch set 6
V -107/12/24, 20:46Use distinct page tsconfig -
core-ci voted on patch set 6 V +1 07/12/24, 20:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61512
-
Garvin Hicking uploaded patch set 7
V +107/12/24, 21:38fix merge conflict -
Garvin Hicking uploaded patch set 8 07/12/24, 21:39
CGL -
core-ci voted on patch set 7 V -1 07/12/24, 21:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61514
-
core-ci voted on patch set 8 V +1 07/12/24, 21:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61515
-
Garvin Hicking commented on patch set 8 07/12/24, 22:06
Reply
Following Georgs suggestion I've now implemented this as a distinct page.tsconfig in addition to site sets, applied to the backend, not breaking existing tests and not making the TCA frontend tree unneccessarily complex. -
Georg Ringer voted on patch set 8 CR +1 V +1 07/13/24, 10:35
-
Stefan Bürk commented on patch set 8 CR -1 07/19/24, 12:16
Switch to `[TASK]`Generator.php:81Unneeded empty lineGenerator.php:134No named arguments -> https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/CodingGuidelines/CodingBestPractices/NamedArguments.html#cgl-named-arguments Beside that siteset feature is out of scope of the patch. And I guess we need a switch for TCA tree generation like for the frontend ? -
Stefan Bürk commented on patch set 8 07/19/24, 12:17
Reply
old one slipped in. -
Stefan Bürk voted on patch set 8 CR 0 07/19/24, 12:17
-
Stefan Bürk commented on patch set 8 07/19/24, 12:18
Generator.php:81Replywrong patchset. sry for that.Generator.php:134Replywrong patchset. sry for that. -
Christian Kuhn voted on patch set 8 CR +2 V +2 07/19/24, 13:20
-
Christian Kuhn merged patch set 9 07/19/24, 13:20