Review main Merged

84521[TASK] Showcase colorPalette in EXT:styleguide

Garvin Hicking CR +2 V +2 Easy +40 −1 updated 07/19/24, 13:20

Commit message

An example colorPalette picker is utilized for
the new field `tx_styleguide_elements_basic.color_palpreset`.

By default all defined colors available to palettes are
used as a fallback, so every colorpicker will receive
these palettes now. `color_palpreset` has a limited palette to
showcase both fallback and specific choice of colors.

A custom page.tsconfig is added, independent from the
Site Set file, to apply this to the backend.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 3

Files 2

Review log 2230

Show 35 earlier messages
  1. Garvin Hicking uploaded patch set 1 06/07/24, 08:19

  2. core-ci voted on patch set 1 V +1 06/07/24, 08:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58859

  3. Garvin Hicking uploaded patch set 2 V +1 06/07/24, 08:53

    Use distinct palette
  4. core-ci voted on patch set 2 V +1 06/07/24, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58863

  5. Garvin Hicking updated the commit message in patch set 3 V +1 06/07/24, 09:01

  1. core-ci voted on patch set 3 V +1 06/07/24, 09:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58864

  2. Georg Ringer voted on patch set 3 CR +1 V +1 06/07/24, 11:06

  3. Christian Kuhn updated the commit message in patch set 4 CR +1 V +1 06/10/24, 17:28

  4. core-ci voted on patch set 4 V +1 06/10/24, 17:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59060

  5. Christian Kuhn commented on patch set 4 CR -1 06/10/24, 17:37

    i don't get it. recreating example tca tree does not reveal anything.
  6. Garvin Hicking commented on patch set 4 06/10/24, 17:48

    Reply

    This could be some problem with Site Set resolving or so, not related with this patch per se. I only got it to work when I edited the "TCA Tree" and included "Styleguide" as a TSconfig resource.
  7. Garvin Hicking uploaded patch set 5 CR -1 V +1 06/13/24, 07:24

    Enable site set for TCA backend tree
  8. Garvin Hicking commented on patch set 4 06/13/24, 07:26

    I've now made the TCA backend tree generator utilize the Site Set in the backend and think that would be helpful there, would love to get feedback for this. I can also create a distinct Site Set for it, or specify a "legacy" page.tsconfig file - but I'd really like to avoid duplication here when the current Site Set would neatly apply to the TCA tree in the backend too.
  9. Garvin Hicking commented on patch set 5 06/13/24, 07:26

    Reply

    Done
  10. core-ci voted on patch set 5 V -1 06/13/24, 07:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59410

  11. Garvin Hicking commented on patch set 5 06/13/24, 10:20

    Meh. Acceptance tests fail because the TCA tree was used to verify that "no typoscript records" exist. Solutions: 1. Create a second backend tree (which is used for that test) without TS 2. Utilize TS only for a sub-part of the TCA tree (so that the colorpicker works), not using the site set Kinda undecided. Oppinions?
  12. Garvin Hicking uploaded patch set 6 V -1 07/12/24, 20:46

    Use distinct page tsconfig
  13. core-ci voted on patch set 6 V +1 07/12/24, 20:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61512

  14. Garvin Hicking uploaded patch set 7 V +1 07/12/24, 21:38

    fix merge conflict
  15. Garvin Hicking uploaded patch set 8 07/12/24, 21:39

    CGL
  16. core-ci voted on patch set 7 V -1 07/12/24, 21:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61514

  17. core-ci voted on patch set 8 V +1 07/12/24, 21:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61515

  18. Garvin Hicking commented on patch set 8 07/12/24, 22:06

    Reply

    Following Georgs suggestion I've now implemented this as a distinct page.tsconfig in addition to site sets, applied to the backend, not breaking existing tests and not making the TCA frontend tree unneccessarily complex.
  19. Georg Ringer voted on patch set 8 CR +1 V +1 07/13/24, 10:35

  20. Stefan Bürk commented on patch set 8 CR -1 07/19/24, 12:16

    Switch to `[TASK]`

    Generator.php:81

    Unneeded empty line

    Generator.php:134

    No named arguments -> https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/CodingGuidelines/CodingBestPractices/NamedArguments.html#cgl-named-arguments Beside that siteset feature is out of scope of the patch. And I guess we need a switch for TCA tree generation like for the frontend ?
  21. Stefan Bürk commented on patch set 8 07/19/24, 12:17

    Reply

    old one slipped in.
  22. Stefan Bürk voted on patch set 8 CR 0 07/19/24, 12:17

  23. Stefan Bürk commented on patch set 8 07/19/24, 12:18

    Generator.php:81 Reply

    wrong patchset. sry for that.

    Generator.php:134 Reply

    wrong patchset. sry for that.
  24. Christian Kuhn voted on patch set 8 CR +2 V +2 07/19/24, 13:20

  25. Christian Kuhn merged patch set 9 07/19/24, 13:20