Review main Merged

84522[BUGFIX] Fix color preview in color picker component

Andreas Kienast CR +2 V +2 Easy +7 −7 updated 06/07/24, 08:58

Commit message

With the upgrade of alwan to 2.x, CSS was completely overhauled. This
snuck in some issue regarding the color previews, where always either a
dark or light background was rendered, depending on user configuration.

This commit fixes the CSS to use the internal `--color` custom property,
which reflects the actual color value.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 45

  1. Andreas Kienast uploaded patch set 1 06/07/24, 08:39

  2. core-ci voted on patch set 1 V +1 06/07/24, 08:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58861

  3. Garvin Hicking commented on patch set 1 CR +1 V +1 06/07/24, 08:50

    Works for me now
  4. Georg Ringer voted on patch set 1 CR +2 V +2 06/07/24, 08:58

  5. Georg Ringer merged patch set 2 06/07/24, 08:58