Review main Merged

84523[TASK] Add page id to some bookmark titles

Georg Ringer CR +2 V +2 Easy +5 −1 updated 06/13/24, 18:14

Commit message

The bookmark title within the following modules is enriched by the page
id:

- Info module

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1215

  1. Georg Ringer uploaded patch set 1 06/07/24, 09:24

  2. Georg Ringer commented on patch set 1 06/07/24, 09:24

    This change is ready for review.
  3. Garvin Hicking voted on patch set 1 CR +1 V +1 06/07/24, 09:28

  4. core-ci voted on patch set 1 V +1 06/07/24, 09:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58866

  5. Christian Kuhn commented on patch set 1 06/07/24, 13:15

    PageTsConfigRecordsOverviewController.php:210

    the tsconfig overview view is identical on all pages. why have a page id in the title? what did i miss?
  6. Georg Ringer commented on patch set 2 CR +1 V +1 06/11/24, 17:06

    Published edit on patch set 1.
  7. Georg Ringer updated the commit message in patch set 3 06/11/24, 17:06

  8. core-ci voted on patch set 2 V +1 06/11/24, 17:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59219

  9. core-ci voted on patch set 3 V +1 06/11/24, 17:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59220

  10. Garvin Hicking voted on patch set 3 CR +1 V +1 06/13/24, 12:16

  11. Christian Kuhn voted on patch set 3 CR +1 V +1 06/13/24, 12:49

  12. Garvin Hicking commented on patch set 3 06/13/24, 14:25

    PageTsConfigRecordsOverviewController.php:210 Reply

    Done (Georg removed that one)
  13. Benni Mack voted on patch set 3 CR +1 V +1 06/13/24, 18:13

  14. Benni Mack voted on patch set 3 CR +2 V +2 06/13/24, 18:14

  15. Benni Mack merged patch set 4 06/13/24, 18:14