84524[TASK] Provide list of available locales in Install Tool
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 4
Review log 3747
Show 1622 earlier messages
-
Georg Ringer uploaded patch set 1 06/07/24, 10:29
-
Georg Ringer commented on patch set 1 06/07/24, 10:29
This change is ready for review. -
core-ci voted on patch set 1 V -1 06/07/24, 10:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58870
-
Georg Ringer commented on patch set 2
V -106/07/24, 10:39Published edit on patch set 1. -
Georg Ringer rebased onto patch set 3 06/07/24, 10:39
-
core-ci voted on patch set 2 V +1 06/07/24, 10:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58871
-
core-ci voted on patch set 3 V +1 06/07/24, 10:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58872
-
Garvin Hicking commented on patch set 3 06/07/24, 15:42
Looks good for a first reading, but can only properly test next week -
Garvin Hicking uploaded patch set 4
V +106/09/24, 19:27Address empty list -
Garvin Hicking commented on patch set 4 CR +1 V +1 06/09/24, 19:29
Works for me and I think is a worthwile addition, moving the locale listing inside its own class. I think that should work out as a dependency on "core" for the "ext:install". When "exec" is disabled, the list was empty - I've added a distinct output in that case (Before it was "Available locales: : ". -
core-ci voted on patch set 4 V +1 06/09/24, 19:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58959
-
Andreas Kienast rebased onto patch set 5
CR +1V +106/10/24, 15:03 -
Garvin Hicking voted on patch set 5 CR +1 V +1 06/10/24, 15:05
-
core-ci voted on patch set 5 V +1 06/10/24, 15:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59021
-
Benni Mack commented on patch set 5 CR -1 06/10/24, 15:55
The commit message is not good. There is only one sentence and it is repeated twice. -
Garvin Hicking updated the commit message in patch set 6
CR +1V +106/10/24, 16:00 -
Garvin Hicking commented on patch set 6 CR +1 V +1 06/10/24, 16:00
Reply
I agree. How about the updated one? -
core-ci voted on patch set 6 V +1 06/10/24, 16:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59046
-
Franz Holzinger commented on patch set 6 06/13/24, 10:47
There is a duplicate colon separated by a blank inside of the text. Available locales: : de_DE, deutsch, en_US, german -
Franz Holzinger commented on patch set 6 06/13/24, 11:02
The variable $usedLocales should be renamed into $usedNames because in contrast to the variable $locales it only contains the names and not the item array as in the return value. $usedLocales is differs in the type from $locales. -
Franz Holzinger commented on patch set 6 06/13/24, 11:10
Misspelling in comment: Install tool operates in english context only, ==> English -
Christian Kuhn commented on patch set 6 06/13/24, 11:11
not a huge fan in general for v13: i think we should finally get rid of the remaining locales dependencies in core since the approach is doomed. afaik, the only missing detail is money/currency? shouldn't we work into this direction instead of adding this to core at this point in time?
-
Franz Holzinger commented on patch set 6 06/13/24, 11:18
The code line $locales = array_map(static function ($locale) { should be moved down into the following else block. Or is the code-HTML not required only once? -
Benni Mack commented on patch set 6 06/13/24, 11:40
Reply
DoneReply
One thing we also need to consider is where "systemLocale" is evaluated. -
Garvin Hicking commented on patch set 6 06/13/24, 12:35
Reply
Following current extensions employ it: fal_quota, timer, image_autoresize. systemLocale is relevant for: * In conjunction with UTF8filesystem for system-wide (not site-specific) filesystem access (PathUtility::basename(), ::pathinfo(), ::dirname()) * In conjunction with system-wide shell execution (LC_CTYPE) (CommandUtility::escapeShellArguments, EXT:indexed_search FileContentParser::setLocaleForServerFileSystem) Install-Tool also even states "[An empty systemLocale] is fine as long as no UTF-8 file system is used." Due to it's system-relation I don't think it could easily be replaced here. I think merging this doesn't hurt too much for the time being and removing systemLocale will probably hit the wall and not get implemented anytime soon. All the rest already seems to make use of the user/site-specific locale, so money date date should not be affected by this. -
Garvin Hicking uploaded patch set 7
CR +1V +106/13/24, 12:44apply code review suggestions -
Garvin Hicking commented on patch set 7 06/13/24, 12:45
Reply
Ack, doneReply
You're right, yes!Reply
Ack, doneReply
Done -
core-ci voted on patch set 7 V +1 06/13/24, 12:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59482
-
Franz Holzinger voted on patch set 7 V +1 06/13/24, 16:45
-
Franz Holzinger voted on patch set 7 CR +1 06/13/24, 16:45
-
Garvin Hicking voted on patch set 7 CR +1 V +1 06/14/24, 07:21
-
Georg Ringer voted on patch set 7 CR +1 V +1 06/14/24, 08:09
-
Garvin Hicking commented on patch set 7 08/02/24, 07:06
Reply
Could we maybe push this forward as long as locales are there? Ripping this out later on would be easily catchable, and until then it would provide a positive impact on setting up instances and prevent misconfiguration? -
Christian Kuhn commented on patch set 7 CR +1 V +1 08/06/24, 10:10
Reply
Acknowledged -
Christian Kuhn commented on patch set 7 CR 0 V 0 08/06/24, 10:57
Locales.php:318don't like static much, but well ... but please at least set this method @internal -
Benni Mack commented on patch set 8
CR +1V +108/06/24, 13:12Published edit on patch set 7. -
Benni Mack commented on patch set 8 08/06/24, 13:12
Locales.php:318ReplyDone -
Christian Kuhn voted on patch set 8 CR +1 V +1 08/06/24, 13:17
-
Benni Mack voted on patch set 8 CR +1 V +1 08/06/24, 13:19
-
core-ci voted on patch set 8 V -1 08/06/24, 13:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62937
-
core-ci commented on patch set 8 08/06/24, 13:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62937
-
Benni Mack rebased onto patch set 9
CR +1V +108/06/24, 13:38 -
core-ci voted on patch set 9 V +1 08/06/24, 13:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62941
-
Christian Kuhn voted on patch set 9 CR +1 V +1 08/06/24, 13:44
-
Benni Mack voted on patch set 9 CR +1 V +1 08/06/24, 13:45
-
Christian Kuhn voted on patch set 9 CR +2 V +2 08/06/24, 14:11
-
Christian Kuhn merged patch set 10 08/06/24, 14:11