Review main Merged

84529[TASK] Replace invalid icon with working example

Georg Ringer CR +2 V +2 Easy +3 −3 updated 06/18/24, 06:49

Commit message

The backend layout wizard now uses a working example by using an
existing icon.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Nikita Hovratov +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1012

  1. Georg Ringer uploaded patch set 1 06/08/24, 08:02

  2. Georg Ringer commented on patch set 1 06/08/24, 08:02

    This change is ready for review.
  3. core-ci voted on patch set 1 V -1 06/08/24, 08:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58910

  4. Garvin Hicking commented on patch set 1 06/08/24, 10:34

    @georg.ringer@gmail.com I think the -1 CI is due to an older grunt workflow for the committed file, did you do a runTests clean build, and a npm ci to use recent versions? (only on mobile today can't execute myself)
  5. Jasmina Ließmann uploaded patch set 2 V -1 06/08/24, 17:11

  6. core-ci voted on patch set 2 V +1 06/08/24, 17:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58921

  7. Jasmina Ließmann commented on patch set 2 06/08/24, 17:33

    Reply

    Did a new runTests.sh Build.
  8. Garvin Hicking commented on patch set 2 CR +1 V +1 06/08/24, 19:29

    Thanks Jasmina! 😊
  9. Nikita Hovratov voted on patch set 2 CR +1 06/09/24, 09:18

  10. Benni Mack voted on patch set 2 CR +1 V +1 06/17/24, 19:47

  11. Georg Ringer voted on patch set 2 CR +2 V +2 06/18/24, 06:49

  12. Georg Ringer merged patch set 3 06/18/24, 06:49