84530[TASK] Mitigate PHPUnit `NameAlreadyInUseException`
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Andreas Wolf +1
-
Verified V +2 Done
- Christian Kuhn +2
- Andreas Wolf +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1722
-
Stefan Bürk uploaded patch set 1 06/08/24, 15:39
-
Stefan Bürk updated the commit message in patch set 2 06/08/24, 15:42
-
core-ci voted on patch set 1 V +1 06/08/24, 15:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58917
-
core-ci voted on patch set 2 V +1 06/08/24, 15:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58919
-
Thomas Hohn voted on patch set 2 CR +1 06/08/24, 16:51
-
Simon Schaufelberger voted on patch set 2 CR +1 V +1 06/08/24, 19:25
-
Andreas Wolf commented on patch set 2 CR +1 06/10/24, 14:54
Just some wording changes and format improvements in the commit message.``` PHPUnit changed the way how double creation is handled internally and now emits an exception if a manually defined `mock class name` should be registered. In some places within the unit tests, manual mock class names have been used, because the names are needed for cross referencing at a later point. For this, different approaches have been used, for example hardcoded MD5 hashes as strings or creating hashes of static values like `md5('1')`, and also reused hashes in different places or in tests using dataproviders. This now leads to an exception: PHPUnit\Framework\MockObject\Generator\NameAlreadyInUseException The name "b70551b2b2db62b6b15a9bbfcbd50614" is already in use This change mitigates the issue by using the `StringUtility::getUniqueId('somePrefix')` as is already done in other places. As a sideeffect, four phpstan baseline entries can be removed. ``` -
Christian Kuhn commented on patch set 2 CR -1 06/10/24, 15:00
too many typos in commit message ;) will push ... -
Christian Kuhn commented on patch set 2 06/10/24, 15:03
andreas wolf will edit. -
Andreas Wolf updated the commit message in patch set 3
CR +1V +106/10/24, 15:03 -
Andreas Wolf updated the commit message in patch set 4 06/10/24, 15:03
-
Christian Kuhn commented on patch set 3 06/10/24, 15:03
Reply
Done -
Andreas Wolf voted on patch set 4 CR +1 06/10/24, 15:04
-
Christian Kuhn updated the commit message in patch set 5
CR +106/10/24, 15:06 -
Andreas Wolf voted on patch set 4 CR +1 V +1 06/10/24, 15:07
-
Andreas Wolf voted on patch set 5 CR +1 V +1 06/10/24, 15:07
-
core-ci voted on patch set 3 V +1 06/10/24, 15:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59023
-
core-ci voted on patch set 4 V +1 06/10/24, 15:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59024
-
Christian Kuhn commented on patch set 5 CR +1 V +1 06/10/24, 15:17
v12 backport is in sync. will merge when green. -
core-ci voted on patch set 5 V +1 06/10/24, 15:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59027
-
Christian Kuhn voted on patch set 5 CR +2 V +2 06/10/24, 15:41
-
Christian Kuhn merged patch set 6 06/10/24, 15:41